A minor warning is being generated by calling array_key_exists() without ensuring that the 1st argument is an array or a string.

Attaching a small patch to fix it.

CommentFileSizeAuthor
#5 easy-breadcrumb_fix-array-key-exists-warning-2906809-5.patch708 bytesluksak
#4 easy-breadcrumb_fix-array-key-exists-warning-2906809-4.patch1.56 KBluksak
#3 easy-breadcrumb_fix-array-key-exists-warning-2906809-3.patch1.56 KBluksak
#2 easy-breadcrumb_fix-array-key-exists-warning-2906809-2.patch734 bytesrenaudcuny

Comments

renaudcuny created an issue. See original summary.

renaudcuny’s picture

renaudcuny commented
StatusFileSize
new easy-breadcrumb_fix-array-key-exists-warning-2906809-2.patch734 bytes
luksak’s picture

luksak
he/him
commented
Priority: Minor » Normal
Status: Active » Needs review
StatusFileSize
new easy-breadcrumb_fix-array-key-exists-warning-2906809-3.patch1.56 KB

I guess the title should rather be casted to a string.

luksak’s picture

luksak
he/him
commented
StatusFileSize
new easy-breadcrumb_fix-array-key-exists-warning-2906809-4.patch1.56 KB

Mixed the patch up with code from another issue. Here is the correct patch.

luksak’s picture

luksak
he/him
commented
StatusFileSize
new easy-breadcrumb_fix-array-key-exists-warning-2906809-5.patch708 bytes

Let's hope I got it right this time :)

luksak’s picture

luksak
he/him
commented
Status: Needs review » Needs work

Actually the patch in #2 works better than mine. The values of $title differ quite a bit depending on the page the breadcrumb is for:

  • Just a string
  • A render array of type markup
  • A \Drupal\Core\StringTranslation\TranslatableMarkup object

What needs to be done here?

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

We should write code for each of the 3 options I suppose. How do you generate a page with the later two options?

luksak’s picture

luksak
he/him
commented

It would just rendered in a Twig file, right?

gg24’s picture

gg24 commented

I see https://www.drupal.org/project/easy_breadcrumb/issues/2925736 as the same issue. Here we are trying to fix the same with different approach. Please check.

Thanks!

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Yea, we can close this issue as a duplicate now as I believe gargsuchi has given us a more robust solution in her thread. Yes? No?

~Greg

luksak’s picture

luksak
he/him
commented
Status: Needs work » Closed (duplicate)
Related issues: +#2925736: Warning: array_key_exists(): The first argument should be either a string or an integer in Drupal\easy_breadcrumb\EasyBreadcrumbBuilder->build()

Since the other issue is fixed, I'm closing this issue.