I have an icon URL set on the module config page (admin/config/services/slack/config). When I send from the test (admin/config/services/slack/test) the icon comes through. When I send using a rule, the icon does not. Looking at the code, it falls back to the default icon when one is not specified in the rule, but it doesn't fall back to the default icon type when one is not specified in the rule. A patch is incoming to fix this.

CommentFileSizeAuthor
#2 default_icon_type-2905941-2.patch440 byteskpaxman

Comments

kpaxman created an issue. See original summary.

kpaxman’s picture

kpaxman commented
StatusFileSize
new default_icon_type-2905941-2.patch440 bytes

Patch is attached against 7.x-1.6, but also confirmed the issue exists in 7.x-1.x and the same patch still cleanly applies.

kpaxman’s picture

kpaxman commented
Status: Active » Needs review
adci_contributor’s picture

adci_contributor commented

Hi, kpaxman. Thank you for helping us make the module better.
We added your patch to our module. And soon there will be a new release of this module with your changes.
Best regards

adci_contributor’s picture

adci_contributor commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.