As discovered by @Wim Leers in #2863607: Convert WebTestBaseTests of BigPipe to BrowserTestBase \Drupal\Tests\BrowserTestBase::checkForMetaRefresh is currently case sensitive and only allows a capitalised meta[http-equiv="Refresh"].

Since \Symfony\Component\HttpFoundation\RedirectResponse::__construct uses a lowercase meta[http-equiv="refresh"] we need to check for both.

CommentFileSizeAuthor
#5 2905818-5.patch3.97 KBwim leers
#5 interdiff.txt2.43 KBwim leers
#4 2905818-4.patch3.54 KBwim leers
#4 2905818-4-test-only-FAIL.patch2.75 KBwim leers
#2 2905818-2.patch3.56 KBlendude

Comments

Lendude created an issue. See original summary.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
Related issues: +#2863607: Convert WebTestBaseTests of BigPipe to BrowserTestBase
StatusFileSize
new 2905818-2.patch3.56 KB

Here is the fix from #2863607: Convert WebTestBaseTests of BigPipe to BrowserTestBase (credit @Wim Leers), plus a test.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Should we upload a pass fail patches as well?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new 2905818-4-test-only-FAIL.patch2.75 KB
new 2905818-4.patch3.54 KB

Yes, I was just doing that.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +blocker
StatusFileSize
new interdiff.txt2.43 KB
new 2905818-5.patch3.97 KB 
  1. +++ b/core/modules/system/tests/modules/test_page_test/src/Controller/Test.php
@@ -1,6 +1,8 @@
 namespace Drupal\test_page_test\Controller;
+use Drupal\Core\Url;
+use Symfony\Component\HttpFoundation\RedirectResponse;

    Nit: whitespace. 

  2. +++ b/core/modules/system/tests/modules/test_page_test/src/Controller/Test.php
@@ -108,4 +110,11 @@ public function renderPipeInLink() {
+  /**
+   * Loads a page that does a redirect.
+   */
+  public function metaRefresh() {
+    return new RedirectResponse(Url::fromRoute('test_page_test.test_page', [], ['absolute' => TRUE])->toString(), 302);
+  }

    This is a bit hard to understand. I think a comment could help here. 

  3. +++ b/core/tests/Drupal/FunctionalTests/BrowserTestBaseTest.php
@@ -605,4 +605,22 @@ public function testLocalTimeZone() {
+   * Tests redirecting using the checkForMetaRefresh method.

    Nit: Let's make this comment consistent with others in this test class.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

Thanks @Wim Leers. Still RTBC.

The last submitted patch, 4: 2905818-4-test-only-FAIL.patch, failed testing. View results

  • larowlan committed aae0baf on 8.5.x 
    Issue #2905818 by Wim Leers, Lendude: Make sure \Drupal\Tests\...

  • larowlan committed 087c5cd on 8.4.x 
    Issue #2905818 by Wim Leers, Lendude: Make sure \Drupal\Tests\...

larowlan credited larowlan.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed as aae0baf and pushed to 8.5.x.

Cherry-picked as 087c5cd and pushed to 8.4.x.

Thanks for splitting this one off.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

That was … surprisingly fast! Thanks, @Lendude + @larowlan!

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented

Blink your eyes and it's in already. Nice work, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.