Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As discovered by @Wim Leers in #2863607: Convert WebTestBaseTests of BigPipe to BrowserTestBase \Drupal\Tests\BrowserTestBase::checkForMetaRefresh is currently case sensitive and only allows a capitalised meta[http-equiv="Refresh"].
Since \Symfony\Component\HttpFoundation\RedirectResponse::__construct
uses a lowercase meta[http-equiv="refresh"] we need to check for both.
Comment | File | Size | Author |
---|---|---|---|
#5 | 2905818-5.patch | 3.97 KB | Wim Leers |
Comments
Comment #2
LendudeHere is the fix from #2863607: Convert WebTestBaseTests of BigPipe to BrowserTestBase (credit @Wim Leers), plus a test.
Comment #3
jibranLooks good to me. Should we upload a pass fail patches as well?
Comment #4
Wim LeersYes, I was just doing that.
Comment #5
Wim LeersNit: whitespace.
This is a bit hard to understand. I think a comment could help here.
Nit: Let's make this comment consistent with others in this test class.
Comment #6
jibranThanks @Wim Leers. Still RTBC.
Comment #11
larowlanCommitted as aae0baf and pushed to 8.5.x.
Cherry-picked as 087c5cd and pushed to 8.4.x.
Thanks for splitting this one off.
Comment #12
Wim LeersThat was … surprisingly fast! Thanks, @Lendude + @larowlan!
Comment #13
LendudeBlink your eyes and it's in already. Nice work, thanks all!