When using basic_auth, if I get any fails inserted into the flood table, they will be ignored by flood_unblock.

For example, this is how my flood table looks like:

|  18 | basic_auth.failed_login_user | 2-10.20.1.1 | 1504135240 | 1504135840 |
|  19 | basic_auth.failed_login_ip   | 10.20.1.1   | 1504135240 | 1504135540 |

And if I try to list or delete from flood_unblock, it will fail.

CommentFileSizeAuthor
#4 get_delete_methods_in-2905765-4.patch1.94 KBdabito

Comments

dabito created an issue. See original summary.

dabito’s picture

dabito commented
Title: Get/delete methods and form ignoring basic_auth.* events » Get/delete methods in FloodUnblockManager class and in the form are ignoring basic_auth.* events
dabito’s picture

dabito commented
Issue summary: View changes
dabito’s picture

dabito commented
StatusFileSize
new get_delete_methods_in-2905765-4.patch1.94 KB

I did a quick fix using like % for the conditions. I think this can be improved later, but in the meantime, this fix works for basic_auth.* events.

dabito’s picture

dabito commented
Status: Active » Needs review

Updated to Needs Review

  • fabianderijk committed cd2bd80 on 8.x-1.x authored by dabito 
    Issue #2905765 by dabito: Get/delete methods in FloodUnblockManager...

fabianderijk credited fabianderijk.

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Needs review » Fixed

Thanks for the patch and support. The issue has been fixed in the new 8.x-1.4 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.