Closed (fixed)
Project:
Drupal core
Version:
8.5.x-dev
Component:
rest.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Aug 2017 at 16:44 UTC
Updated:
12 Dec 2017 at 16:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
wim leersComment #3
wim leers#2800873: Add XML GET REST test coverage, work around XML encoder quirks is in, now we can continue here.
Comment #4
wim leersI think just
PATCHtest coverage is enough.Here's that test coverage.
Comment #5
wim leersComment #6
dawehnerThis looks perfect, thank you!
For a while I was thinking, could we make this file more readable overall by introducing readable helper functions like:
patchMultiValueFields. This would be of course out of scope here, but such big functions don't make it obvious without reading them from top to the bottom of all the possible cases it covers.Comment #7
wim leersI agree — now that the test coverage is approaching completion, we can and should look into simplifying it!
Comment #9
wim leersLooks like catch committed this one, yay! :)