Closed (fixed)
Project:
ImageCache Actions
Version:
7.x-1.x-dev
Component:
Color Actions Module
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
28 Aug 2017 at 15:07 UTC
Updated:
24 Nov 2017 at 09:01 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
bserem commentedComment #3
fietserwinIn fact, GD does not support animations at all and thus will always remove animations upon saving. So this would kind of make the behavior for both toolkits the same.
I will have a look at it, but that will take some weeks, so rest assured that your contribution is taken seriously.
Comment #4
bserem commentedFYI this patch is currently running on solebich.de (all listing pages), which is a photo oriented site.
With PHP7 on a BOA server we haven't faced any problems yet.
Thanks for checking it.
Comment #5
fietserwinThanks for posting this effect. I tested it and it works as expected. I do have a few comments though:
I am not sure about inanimate as verb, so I would like to propose "remove animation" as user facing name of the effect.
@dman: as native English speaker: can you confirm that "inanimate" does or doesn't exist as verb?
I would rephrase this to something like: "... by keeping only the first frame ..."
image_toolkit_invoke() logs an error when using GD, so I propose to add an empty image_gd_inanimate() function (returning TRUE as GD will remove animation anyway).
Furthermore; our effects that do not have any parameters (like autorotate and invert colors) still have a(n empty) form. i would like to see that for this effect as well, in which we can explain that this effect only works for imagemagick and that gd cannot handle animation at all and thus will always only keep the 1st frame.
Comment #6
dman commented> can you confirm that "inanimate" does or doesn't exist as verb?
Heh, no, I'd never hear or use "inanimate". "Remove animation" is indeed clear.
Could also "halt" or "freeze" it, but in this context (file manipulation) "remove" is indeed probably best.
For the second string, "return t(': Freezes an animated image, keeping only the first frame.');"
Comment #7
bserem commentedInanimate is not a verb (but it is a valid word). So I will update the texts.
I am wokring on the other issues too, an updated patch will come as soon as I have it ready.
Many thanks for the feedback!
Comment #8
bserem commentedI believe I'm on the right track!
Please review and tell me what you think.
Comment #9
bserem commentedComment #11
fietserwinThanks for updating the patch. I changed a few more things and committed it, see attached interdiff,txt. Note: as I renamed the internal name of the effect as well, your existing site will not recognise this new version: remove and re-add the effect.
Comment #13
bserem commentedThanks!
Comment #14
fietserwinif and what name(s) and links would you like to be mentioned on the project page under the "Credits/sponsors" section?
Comment #16
bserem commentedThat would be: Bill Seremetis (bserem) for solebich.de
Thanks, I wasn't expecting that :)