Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Product
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Aug 2017 at 11:54 UTC
Updated:
14 Sep 2017 at 16:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
czigor commentedComment #3
czigor commentedUnit test is included in the patch.
Comment #4
czigor commented- Using 'commerce_entity_select' instead of a plain 'select'
- Fixing some docblocks.
Comment #5
bojanz commentedYou're injecting the product storage, but never using it.
This key is wrong.
Also, no config schema has been added.
Comment #6
bojanz commentedWhy call it the $product_entity? We don't suffix variables that way.
This is a $product_variation, no?
Comment #8
bojanz commentedAddressed the feedback and committed.