Once again Core broke our tests …

CommentFileSizeAuthor
#3 2904976-3--fix_tests.patch2.31 KBdrunken monkey
#3 2904976-3--fix_tests--interdiff.txt1.4 KBdrunken monkey
#2 2904976-2--fix_tests.patch2.08 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2904976-2--fix_tests.patch2.08 KB

Apparently, this was the problem: EntityListBuilder now adds destination query argument to edit, delete, enable/disable operations.
It's a bit tricky to get the tests to pass on both the old and the new version, but since that change only made it into 8.5.x, I think the variant in the patch should work.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 2904976-3--fix_tests--interdiff.txt1.4 KB
new 2904976-3--fix_tests.patch2.31 KB

Hm, maybe like this?
Forgot to add comments anyways.

  • drunken monkey committed 381824b on 8.x-1.x 
    Issue #2904976 by drunken monkey: Fixed the current test fails.
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Ah, excellent!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.