Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Typo in views UI
an number => a number
patch to follow, thanks!
Comment | File | Size | Author |
---|---|---|---|
#10 | views-8.3.x-fixes-typo-2904748-10.patch | 888 bytes | volkswagenchick |
#10 | views-8.5.x-fix-typo-2904748-10.patch | 888 bytes | volkswagenchick |
#10 | views-8.4.x-fix-typo-2904748-10.patch | 888 bytes | volkswagenchick |
Comments
Comment #2
volkswagenchickFixed typo in UI, patch uploaded. Thanks!
Comment #3
volkswagenchickAdded a patch for the 8.4.x branch as well
Comment #4
volkswagenchickThis is my first patch attempt for drupal core. I had different mentors tell me 3 different branches to use, so here's yet another patch. this one fixes 8.5.x
Thanks for your patience!
Comment #5
volkswagenchickUgh, I noticed another grammar issue in the sentence and am going to put up new patches. To be continued.
Comment #6
dani3lr0se CreditAttribution: dani3lr0se as a volunteer commentedPing me when it's ready and I'll RTBC it.
Comment #7
volkswagenchickUploaded patches that corrected grammar in UI.
Offset must be an number greater or equal than 0. => Offset must be a number greater or equal to 0.
8.5.x
8.4.x
8.3.x
Comment #8
volkswagenchickComment #9
volkswagenchickComment #10
volkswagenchickOkay, NOW the grammar is cleaned up and patches are ready to be reviewed.
Comment #11
loopduplicateLooks great :)
Comment #12
cilefen CreditAttribution: cilefen as a volunteer commentedHi @volkswagenchick:
Thank you and congratulations on your first patch! 😁
There are some minor things to know that don't affect the quality of the work you have done but it will be good to know going forward:
You need not write separate patches for every branch if the same patch applies to all. The patch files may be identical—I did not check.
This change will likely not make it into 8.3.x because it changes a translatable string. I can explain more on that if you like.
Thanks and please post more patches and reviews and NEVER STOP!!!
Comment #13
volkswagenchickThankyou @cilefen for your kind words...I have helped with contrib modules in the past, but this is the first patch I have done in Core. Your insights about the branching are appreciated and thanks again for the encouragement!
Comment #14
webchickNice find!
Committed and pushed to 8.5.x and cherry-picked to 8.4.x. Thanks! :D Here's hopefully to many more core patches from you! :)
Comment #17
webchick