Typo in views UI
an number => a number
patch to follow, thanks!

CommentFileSizeAuthor
#10 views-8.3.x-fixes-typo-2904748-10.patch888 bytesvolkswagenchick
#10 views-8.5.x-fix-typo-2904748-10.patch888 bytesvolkswagenchick
#10 views-8.4.x-fix-typo-2904748-10.patch888 bytesvolkswagenchick
#7 views-8.3.x-fix-typo-2904748-6.patch883 bytesvolkswagenchick
#7 views-8.4.x-fix-typo-2904748-6.patch883 bytesvolkswagenchick
#7 views-8.5.x-fix-typo-2904748-6.patch883 bytesvolkswagenchick
#4 views-fix-typo-2904748-4.patch885 bytesvolkswagenchick
#3 views-fix-typo-2904748-3.patch885 bytesvolkswagenchick
#2 views-fix-typo-2904748-2.patch885 bytesvolkswagenchick

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs work » Needs review
StatusFileSize
new views-fix-typo-2904748-2.patch885 bytes

Fixed typo in UI, patch uploaded. Thanks!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new views-fix-typo-2904748-3.patch885 bytes

Added a patch for the 8.4.x branch as well

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new views-fix-typo-2904748-4.patch885 bytes

This is my first patch attempt for drupal core. I had different mentors tell me 3 different branches to use, so here's yet another patch. this one fixes 8.5.x
Thanks for your patience!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Active

Ugh, I noticed another grammar issue in the sentence and am going to put up new patches. To be continued.

dani3lr0se’s picture

dani3lr0se commented

Ping me when it's ready and I'll RTBC it.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new views-8.5.x-fix-typo-2904748-6.patch883 bytes
new views-8.4.x-fix-typo-2904748-6.patch883 bytes
new views-8.3.x-fix-typo-2904748-6.patch883 bytes

Uploaded patches that corrected grammar in UI.

Offset must be an number greater or equal than 0. => Offset must be a number greater or equal to 0.

8.5.x
8.4.x
8.3.x

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Active » Needs review
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Assigned: volkswagenchick » Unassigned
volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
StatusFileSize
new views-8.4.x-fix-typo-2904748-10.patch888 bytes
new views-8.5.x-fix-typo-2904748-10.patch888 bytes
new views-8.3.x-fixes-typo-2904748-10.patch888 bytes

Okay, NOW the grammar is cleaned up and patches are ready to be reviewed.

loopduplicate’s picture

loopduplicate commented
Version: 8.3.x-dev » 8.5.x-dev
Category: Task » Bug report
Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community

Looks great :)

cilefen’s picture

cilefen commented

Hi @volkswagenchick:

Thank you and congratulations on your first patch! 😁

There are some minor things to know that don't affect the quality of the work you have done but it will be good to know going forward:

You need not write separate patches for every branch if the same patch applies to all. The patch files may be identical—I did not check.

This change will likely not make it into 8.3.x because it changes a translatable string. I can explain more on that if you like.

Thanks and please post more patches and reviews and NEVER STOP!!!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Thankyou @cilefen for your kind words...I have helped with contrib modules in the past, but this is the first patch I have done in Core. Your insights about the branching are appreciated and thanks again for the encouragement!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +String change in 8.4.0

Nice find!

Committed and pushed to 8.5.x and cherry-picked to 8.4.x. Thanks! :D Here's hopefully to many more core patches from you! :)

  • webchick committed 3abc583 on 8.5.x 
    Issue #2904748 by volkswagenchick, loopduplicate, cilefen: Typo in Views...

  • webchick committed e7a4e33 on 8.4.x 
    Issue #2904748 by volkswagenchick, loopduplicate, cilefen: Typo in Views...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.