When there is numeric argument defined for view and 'Exclude' is not selected, there is a trailing space in 'field' key of generated condition.

CommentFileSizeAuthor
#5 2904663-5-num-arg-trailing-space.patch2.45 KBtacituseu
#2 2904663-num-arg-trailing-space.patch1.44 KBtacituseu

Comments

tacituseu created an issue. See original summary.

tacituseu’s picture

tacituseu commented
StatusFileSize
new 2904663-num-arg-trailing-space.patch1.44 KB

What can I say... it bothered me ;)

tacituseu’s picture

tacituseu commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2904663-num-arg-trailing-space.patch, failed testing. View results

tacituseu’s picture

tacituseu commented
Status: Needs work » Needs review
StatusFileSize
new 2904663-5-num-arg-trailing-space.patch2.45 KB

Fixing test that accounted for it.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Status: Needs review » Reviewed & tested by the community

Patch applying fine on my Drupal 8.6.x

Setting it to RTBC.

  • catch committed d97c58a on 8.6.x 
    Issue #2904663 by tacituseu: Trailing space in field part of where...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed d97c58a and pushed to 8.6.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.