We have entity translations set up, and were struggling to get everything working as expected. This is hopefully the last piece of the puzzle, allowing the Views based search to utilise the language hierarchy fallback mechanism.

CommentFileSizeAuthor
#4 2904268-4--integrate_with_language_hierarchy.patch1.47 KBdrunken monkey
#4 2904268-4--integrate_with_language_hierarchy--interdiff.txt1.31 KBdrunken monkey
#2 search_api-language_hierarchy_support-2904268-2.patch2 KBpobster
#2 Screen Shot 2017-08-23 at 23.17.24.png69.69 KBpobster

Comments

pobster created an issue. See original summary.

pobster’s picture

pobster commented
StatusFileSize
new Screen Shot 2017-08-23 at 23.17.24.png69.69 KB
new search_api-language_hierarchy_support-2904268-2.patch2 KB

Query works okay.

pobster’s picture

pobster commented
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: -views integration
StatusFileSize
new 2904268-4--integrate_with_language_hierarchy--interdiff.txt1.31 KB
new 2904268-4--integrate_with_language_hierarchy.patch1.47 KB

Thanks a lot for reporting this issue and providing a patch!
I don't know that module, but your patch looks simple enough (and also pretty good), and if you say it works, that's good enough for me. It should, in any case, not affect anyone not using that module.
However, to be consistent with the other two "special" values, could we use 'fallback' for the option key?
Also, the global is already imported at the start of the query() method, no need to do it again.

Please tell me if the attached patch still works for you and I will commit it.

PS: It seems you (like many others – it's really easy to misinterpret) are confused by the "Issue tags" field. As the guidelines state, they aren't meant for free text tags related to the issue, but only for specific categorization purposes, usually by module maintainers.
So, if you aren't sure your current usage is correct, please just leave the field empty.

pobtastic’s picture

pobtastic commented
Status: Needs review » Reviewed & tested by the community

Yeah thank you, LGTM +1 :o)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Why the two accounts?
Anyways, thanks for reporting back, and good to hear it still works for you.
Committed.
Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.