Problem/Motivation

#2819871: Make it clear that Embed isn't compatible with Entity Browsers that use the 'Modal' display plugin made it clear that modal entity forms for example are not compatible with entity_browser, still its allowed for people to configure this non working configuration.

Proposed resolution

On top of that I suggest that they should not be able to select the option in the first place. Much like the modal the standalone form is broken as well, well, because it was meant to be used different as well in the first place.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 2904091-4.patch1.26 KBdawehner
#2 2904091-2.patch1.21 KBdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 2904091-2.patch1.21 KB

Here is this small UX improvement.

Status: Needs review » Needs work

The last submitted patch, 2: 2904091-2.patch, failed testing. View results

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 2904091-4.patch1.26 KB

This time with actual no PHP error.

Status: Needs review » Needs work

The last submitted patch, 4: 2904091-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Filter out incompatible entity browsers on the configuration form » [entity_browser] Filter out incompatible entity browsers on the configuration form
Status: Needs work » Closed (duplicate)
Related issues: +#2820188: [entity_browser] Errors when using a modal/standalone Entity Browser, because modal-in-modal does not work

Merged this into #2820188, which had a more complete solution, more buy-in, more people having tested it and was older. None of your logic was lost though :)