Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Checkout
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Aug 2017 at 17:47 UTC
Updated:
6 Sep 2017 at 13:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mglamanHere is a patch which adds the order as cacheable dependency. This means the checkout flow cache will basically be busted if the order refreshes. Such as someone decided to sit on the checkout for a few minutes or a few hours.
Comment #3
mglamanPR https://github.com/drupalcommerce/commerce/pull/777
Needed patch to manually test. But this really needs a proper test.
Comment #4
mglamanAdds test. Interestingly enough the cache tags were part of the page cache from elsewhere. However not in the form. So without explicitly adding them to the checkout flow's form render array, it did not cause a MISS in the dynamic cache.
Build with fix commented out and test: https://travis-ci.org/drupalcommerce/commerce/builds/267327175?utm_sourc...
Build with fix and test: https://travis-ci.org/drupalcommerce/commerce/builds/267327689?utm_sourc...
Comment #5
mglamanUpdated patch which asserts modifying the config entity will also bust cache.
Comment #8
bojanz commentedThere's no way this is the last bug we have here. But at least we've made a start.