CommentFileSizeAuthor
#8 2903324-workbench-toolbar.patch436 bytesagentrickard
#7 Screen Shot 2017-08-23 at 10.27.26 AM.png58.67 KBagentrickard
#3 screenshot-before-after.png29.57 KBmaninders

Comments

Maninders created an issue. See original summary.

j2r’s picture

j2r commented
Priority: Critical » Normal
Status: Active » Needs review
StatusFileSize
new workbench-fix-menu-2903324-1.patch386 bytes
maninders’s picture

maninders commented
StatusFileSize
new screenshot-before-after.png29.57 KB

Submenu is not showing after enabling Workbench Module.
Screenshot is attached of before and after.

maninders’s picture

maninders commented
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Postponed (maintainer needs more info)

Please use words to describe hoe to reproduce this error.

* What menus are configured?
* How are they supposed to appear?

etc.

I need steps to reproduce the error.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Postponed (maintainer needs more info) » Active

I take that back, the screenshot is clear. My apologies.

This is probably a JavaScript conflict.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new Screen Shot 2017-08-23 at 10.27.26 AM.png58.67 KB

Something about how the toolbar works doesn't like it when Workbench is in the first position. The menu level-1 class isn't applied to the Manage items.

If we move it, it works. But there has to be a better solution.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review
StatusFileSize
new 2903324-workbench-toolbar.patch436 bytes

Here's a patch that seems to fix the issue for me locally.

Can you apply, clear cache, and see if it works?

j2r’s picture

j2r commented

Hi agentrickard

I have provided similar patch in #2
I didnt removed the
'#type' => 'container',

as it seems like the issue is with the class and workbench is not using that class anyway to remove it will fix the issue and it does not cause style issue.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Reviewed & tested by the community

Sorry. I totally skipped over the patch yesterday. Yours is fine.

Thanks!

  • agentrickard committed df26c67 on 8.x-1.x authored by j2r 
    Issue #2903324 by agentrickard, Maninders, j2r: D8 - Submenu is not...
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.