Simple GMAP has had a few releases since the version in Panopoly:

I've also posted a patch to improve accessibility by adding a configurable iframe title to the formatter output: #2902178: Add title attribute to iframe (7.x). Once that's finished being reviewed, it'd be nice to get all this in to Panopoly.

CommentFileSizeAuthor
#3 panopoly_widgets-update_simple_gmap-2903251-3.patch1.36 KBbyronveale
#2 panopoly_widgets-update-simple_map-2903251-2.patch523 bytesdsnopek

Comments

cboyden created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new panopoly_widgets-update-simple_map-2903251-2.patch523 bytes

Here's a patch for this!

EDIT: Here's a Travis build: https://travis-ci.org/panopoly/panopoly/builds/323068326

byronveale’s picture

byronveale commented
StatusFileSize
new panopoly_widgets-update_simple_gmap-2903251-3.patch1.36 KB

Panopoly Widgets feature was coming up overridden; this took care of it for me locally…

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Reviewed & tested by the community

We've had this in production for weeks w/o issue.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Here's a Travis build for the latest patch:

https://travis-ci.org/panopoly/panopoly/builds/353055135

Mainly need to verify that that'll fix the overridden issue on the last build

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

I did some testing of the Map widget with this update and everything worked great! Mainly, I'm just waiting for a successful test run, and then this'll get merged.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Troubles with the tests! Here's a new build, where at least the update build should work:

https://travis-ci.org/panopoly/panopoly/builds/353489056

  • dsnopek committed 19d2dd0 on 7.x-1.x 
    Update Panopoly Widgets for Issue #2903251 by dsnopek, byronveale,...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

The test failures here are the same as happening on all tests:

There's nothing map specific in there. So, I'm just going to go ahead and commit this one!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.