Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Other
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Aug 2017 at 15:44 UTC
Updated:
8 Sep 2017 at 04:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jsacksick commentedComment #3
jsacksick commentedComment #4
bojanz commentedComment #6
bojanz commentedComment #7
edaa commentedIt does not work on Drupal 8.4.x, I know Commerce 2.x does not support Drupal 8.4 until it's stable, maybe it's useful for someone.
Because the base class
DefaultSingleLazyPluginCollectionofPaymentGatewayPluginCollectionandTaxTypePluginCollectionis actually not lazy, the plugin in them will be initialized before their_constructorcompleted, the plugin'sentityIdis always NULL.For example
PaymentGatewayPluginCollection:We need to set entityId earlier:
Comment #8
edaa commentedComment #9
bojanz commented@edwardaa
Can you please open a separate issue for this? If Drupal 8.4 introduced a regression, we should find in which issue it happened.
Comment #10
edaa commentedIssue #2904570: $this->entityId always NULL in plugins in Drupal 8.4.x created.