See https://www.drupal.org/node/2578077#comment-12225769

Basically, when you install the module, and there is no memcache library available, drupal_check_module assumes there will be a description key set. So let's just set that for the install case where there is a REQUIREMENT_ERROR.

CommentFileSizeAuthor
#8 2903077-8.patch1.62 KByas
#5 2903077-5.patch1.94 KByas
#2 2903077.patch1.89 KBdamiankloip

Comments

damiankloip created an issue. See original summary.

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
StatusFileSize
new 2903077.patch1.89 KB

  • damiankloip committed c7531d2 on 8.x-2.x 
    Issue #2903077 by damiankloip, npcoder: Undefined index 'description'...
damiankloip’s picture

damiankloip commented
Status: Needs review » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs review
StatusFileSize
new 2903077-5.patch1.94 KB

This patch causes the following error at a Status report page: e.g. https://example.com/admin/reports/status. The keys in $requirements are confusing amongst 'memcache_extension' and 'memcache_extension_version', 'memcached_extension_version'.

Drupal\system\SystemManager->listRequirements()' requires a 'title' key.

Notice: Undefined index: title in Drupal\system\SystemManager->Drupal\system\{closure}() (line 117 of core/modules/system/src/SystemManager.php).
Drupal\system\SystemManager->Drupal\system\{closure}(Array, Array)
uasort(Array, Object) (Line: 122)
Drupal\system\SystemManager->listRequirements() (Line: 49)
Drupal\system\Controller\SystemInfoController->status()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 574)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 153)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 656)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Please let me suggest the fix with an attached patch.

damiankloip’s picture

damiankloip commented

Sorry, thought it didn't break the title... just removed it! I think we should maybe set the title according to whether memcache or memcached extension is used, and default to 'Memcache' when there are none, like we do now. I like just using the same requirements key for everything though, nice.

damiankloip’s picture

damiankloip commented
Status: Needs review » Needs work
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 2903077-8.patch1.62 KB

@damiankloip

Here we go.

realityloop’s picture

realityloop commented
Status: Needs review » Reviewed & tested by the community

Resolves the issue

  • damiankloip committed b6881b3 on 8.x-2.x authored by yas 
    Issue #2903077 by yas, damiankloip, realityloop: Undefined index '...
damiankloip’s picture

damiankloip commented
Status: Reviewed & tested by the community » Fixed

Committed. Fixed one tiny thing, changed the last string in the patch to 'Memcached version'.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.