Sometimes you need to add addresses as long strings but currently, this format is not supported.

CommentFileSizeAuthor
#14 add_support_for_long-2902500-14.patch1.73 KBphjou
#12 add_support_for_long-2902500-12.patch1.56 KBpcate
#8 add_support_for_long-2902500-8.patch2.05 KBalvar0hurtad0
#8 interdiff.txt1.02 KBalvar0hurtad0
#5 add_support_for_long-2902500-5.patch1.03 KBalvar0hurtad0
#2 add_support_for_long-2902500-2.patch522 bytesalvar0hurtad0

Comments

alvar0hurtad0 created an issue. See original summary.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
StatusFileSize
new add_support_for_long-2902500-2.patch522 bytes

And here's the patch

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: Add support for long strings fields » Add support for long text fields (8.x)
Status: Needs review » Needs work
Issue tags: +Needs tests
Related issues: +#1606756: Add support for long text fields (7.x)

This is a duplicate of #1606756: Add support for long text fields (7.x), although that one is for 7.x and this one is 8.x, so I guess I will leave this open and mark them related, but change the titles so it's clear they are the same issue.

This patch has the same problem as the patch on the 7.x issue. You need to do something about HTML formatting, and line breaks, within the field, or at a minimum, it needs tests for fields containing line breaks and HTML to verify that they work. I don't think they will. (This module now has semi-automated tests for 8.x.)

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
Status: Needs work » Needs review
StatusFileSize
new add_support_for_long-2902500-5.patch1.03 KB

Thanks a lot for the review.
About line-breaks, the formatter is working fine with them. And about the HTML note, that the field type is string_long, not text_long so this format is not eligible for html text fields.

On this test, I've used a string_long field on the second field on the existing test.

I can create a new test if nedded but I think that it covers the new functionallity.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Ah right -- my mistake, I forgot the D8 fields separated out plain vs. formatted text fields. I'll take a closer look, run the tests, etc... thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Quick note that before committing this, we should check the README file and project page and see if any documentation needs to be updated.

alvar0hurtad0’s picture

alvar0hurtad0
he/him
Primary language Spanish
Location Cáceres
commented
StatusFileSize
new interdiff.txt1.02 KB
new add_support_for_long-2902500-8.patch2.05 KB

Here is the patch changing the README.txt

I think that text on project page can apply to both types of fields. But I'm not a native English speaker and maybe my criterion is not the best to decide it.

Thanks :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Thanks for the README update. I'll make some time to review/test this later this week.

pcate’s picture

pcate commented

Patch #8 worked fine for me. This feature makes it a lot easier to enter addresses.

pcate’s picture

pcate commented
Status: Needs review » Reviewed & tested by the community
pcate’s picture

pcate commented
StatusFileSize
new add_support_for_long-2902500-12.patch1.56 KB

Partial patch re-roll for latest dev. Does not include test from #8 as the test module structure has changed for the module.

pcate’s picture

pcate commented
Status: Reviewed & tested by the community » Needs work
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new add_support_for_long-2902500-14.patch1.73 KB

Rerolled patch.
Also replaced "Drupal 8" by "Drupal" to be more generic in the README.

smustgrave’s picture

smustgrave commented
Version: 8.x-1.x-dev » 4.0.x-dev

  • smustgrave committed 3f4d0297 on 4.0.x 
    Issue #2902500 by alvar0hurtad0, pcate, phjou, jhodgdon: Add support for...
smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.