Problem/Motivation

Reproduce:

  1. go to /update.php:
    hangnail

Proposed resolution

Find and correct the css rules.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#16 2902413-16-D8.patch681 bytesmohit1604
#8 hangnail-fixed.png88.07 KBfisherman90
#7 2902413-7.patch683 bytesAnonymous (not verified)
#2 hangnail_fix.png40.02 KBAnonymous (not verified)
#2 2902413-2.patch681 bytesAnonymous (not verified)
hangnail.png38.56 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

vaplas created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new 2902413-2.patch681 bytes
new hangnail_fix.png40.02 KB

Something like this:
hangnail fix

cilefen’s picture

cilefen commented
Title: Рangnail on the active task in Seven theme » Hangnail on the active task in Seven theme

"Hangnail" right? I assume it's a typo. Interestingly, "pangnail" returns 0 results in Google—no small feat.

Anonymous’s picture

Anonymous (not verified) commented

@cilefen, absolutely) It was typo. Super quick response! Thanks

cilefen’s picture

cilefen commented

I want to be sure everybody is toeing the line.

Anonymous’s picture

Anonymous (not verified) commented

Cool! Then I will explain the reason for the typo. "Рangnail" returns 0 results, because Р - cyrillic symbol (in my keyboard H/Р - one key).

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new 2902413-7.patch683 bytes 
+++ b/core/themes/seven/css/theme/maintenance-page.css
@@ -76,14 +76,14 @@
-    border-width: 1.35em;
+    border-width: 1.28em;

It was a rough approximation. Now I calculated more precisely: 1.269em💎.

This gives for li:after same height like li. Because height of li is 2.538em:

  • line-height: 1.538em;
  • padding-top: 0.5em;
  • padding-bottom: 0.5em;

Height of li:after border-left should be half of this.

Compared with #2 patch, I did not get a visible improvement from this for English and Сyrillic fonts, but this can help in other cases.

fisherman90’s picture

fisherman90
Primary language German
Location Dortmund
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new hangnail-fixed.png88.07 KB

Reviewed and tested patch #7 with 8.5.x-dev and there is no recognizable hangnail anymore.

Looks good, even on retina display with increased size.
(browser > "ctrl" & "+" / "ctrl" & "-").

retina display test

cilefen’s picture

cilefen commented

@vaplas #5 is a pun, by the way. ;-)

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 8.5.x-dev » 8.4.x-dev

I was curious if this was caused by some strange browser behavior and I tested this with all of the modern desktop browsers and some older IE browsers and I could consistently reproduce the bug and see it fixed by the patch.

Committed 3d5d727 and pushed to 8.5.x. Thanks!

I didn't cherry pick this to 8.4.x but as a minor change to internal code, this should be allowed. I will cherry pick the code to 8.4.x after getting confirmation from another committer.

  • lauriii committed 3d5d727 on 8.5.x 
    Issue #2902413 by vaplas, fisherman90: Hangnail on the active task in...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 7: 2902413-7.patch, failed testing. View results

cburschka’s picture

cburschka
they
commented
Status: Needs work » Needs review

I want to be sure everybody is toeing the line.

:D

Back to NR for 8.4.x; the patch just isn't applying to 8.5.x now that it's pushed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Patch (to be ported)

Thanks @lauriii for commit to 8.5! The pre-release time has passed. Perhaps now we can apply this small improvement without agreeing with another committer? Because we just make the same height of the two elements, as it should be.

I do not want to inflate an elephant from a fly. But after discovering this bug I notice it everywhere where screenshots of install/update are used: in articles, screencasts, books, and all drupal sites of course (< 8.5.x). It does not add prestige, isn't it?

mohit1604’s picture

mohit1604 commented
Assigned: Unassigned » mohit1604
mohit1604’s picture

mohit1604 commented
StatusFileSize
new 2902413-16-D8.patch681 bytes

Patch for 8.4.x version.

mohit1604’s picture

mohit1604 commented
Assigned: mohit1604 » Unassigned
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Patch (to be ported) » Fixed

We don't commit anything except critical issue to the 8.4.x. This has been already committed to 8.5.x which gets an alpha release next week. Marking this as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.