$(window)
        .on('resize.off-canvas scroll.off-canvas', eventData, debounce(Drupal.offCanvas.resetSize, 100))
        .trigger('resize.off-canvas');

the dialog defined height value on open stage, we need not resize it on every scroll.

CommentFileSizeAuthor
outside-remove-scroll-event.patch1.3 KBdroplet

Comments

droplet created an issue. See original summary.

droplet’s picture

droplet commented
Status: Active » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs manual testing

@droplet thanks!

I checked the patch manually. Scrolling over main canvas and the dialog itself at different page heights. Everything looks good.

Adding "Needs manual testing" tag because committed should also test this manually

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue tags: -Needs manual testing

I performed the manual testing and this works well (with and without the patch from #2902361: [regression] In Settings Tray when the form is longer than the page body it is tricky to scroll to the very bottom.), please see #2902361-5: [regression] In Settings Tray when the form is longer than the page body it is tricky to scroll to the very bottom. and later for discussion.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented

+1 from me on this. It's a more direct fix and solves the original issue. :)

  • Cottser committed 061f386 on 8.5.x 
    Issue #2902304 by droplet, tedbow: Remove `scroll.off-canvas` event
star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks, everyone!

Committed 061f386 and pushed to 8.5.x.

  • Cottser committed b014032 on 8.4.x 
    Issue #2902304 by droplet, tedbow: Remove `scroll.off-canvas` event

(...
star-szr’s picture

star-szr
he/him
Primary language English
commented
Version: 8.5.x-dev » 8.4.x-dev

No reason I can see to not include this in 8.4.x, cherry-picked there as well.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.