Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
$(window)
.on('resize.off-canvas scroll.off-canvas', eventData, debounce(Drupal.offCanvas.resetSize, 100))
.trigger('resize.off-canvas');
the dialog defined height value on open stage, we need not resize it on every scroll.
Comment | File | Size | Author |
---|---|---|---|
outside-remove-scroll-event.patch | 1.3 KB | droplet | |
Comments
Comment #2
droplet CreditAttribution: droplet commentedComment #3
tedbow@droplet thanks!
I checked the patch manually. Scrolling over main canvas and the dialog itself at different page heights. Everything looks good.
Adding "Needs manual testing" tag because committed should also test this manually
Comment #4
star-szrI performed the manual testing and this works well (with and without the patch from #2902361: [regression] In Settings Tray when the form is longer than the page body it is tricky to scroll to the very bottom.), please see #2902361-5: [regression] In Settings Tray when the form is longer than the page body it is tricky to scroll to the very bottom. and later for discussion.
Comment #5
GrandmaGlassesRopeMan+1 from me on this. It's a more direct fix and solves the original issue. :)
Comment #7
star-szrThanks, everyone!
Committed 061f386 and pushed to 8.5.x.
Comment #9
star-szrNo reason I can see to not include this in 8.4.x, cherry-picked there as well.
Comment #10
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)