[regression] In Settings Tray when the form is longer than the page body it is tricky to scroll to the very bottom.

Patch looks good. Previous issue already determined this was the correct fix.

Prefixing issue title with "[regression]" to distinguish from #2888305: In Settings Tray the when form is longer than page body it is tricky to scroll to the very bottom., which is identically named.

Patch doesn't explain why it will happen. and I think this issue:
#2902304: Remove `scroll.off-canvas` event

Damn, I missed #5 while in the process of reviewing, testing, and committing this patch.

Here's the comment I had drafted:

I remember seeing this when reviewing and going "hmm" but looks like I neglected to include it in my actual review.

I tested manually before and after and confirmed the fix. The gifs in #2888305-6: In Settings Tray the when form is longer than page body it is tricky to scroll to the very bottom. were useful for confirming that I was testing the right thing.

Committed 845b1c6 and pushed to 8.5.x. Thanks!

Going to leave this for now but it might get reverted if the other fix is more correct.

It does look to me like #2902304: Remove `scroll.off-canvas` event fixes this bug in a more direct way. If we can confirm this fix would not needed if #2902304: Remove `scroll.off-canvas` event is committed, then I'll go ahead with reverting this commit but I'd like confirmation from @drpal and/or @tedbow before I go ahead with that in case I'm missing something.

Also,

You should always reload the page and open ONE dialog per time on testing. Otherwise, you may observe a different behavior on debugging:#2902429: Remove previous event handlers when opening new off-canvas block edit form in the off-canvas dialog

(Highly recommend the outside_in team get #2902429 in before other issues to avoid unexpected reflow)

Tweaking title as I did for the commit and setting to NR for now.

Bump, don't really want to revert this without a proper solution (it does make it very hard to use) but I do want to make sure we have the right solution in place :)

Thanks @drpal, reverted and closing as a duplicate.

Changing to new settings_tray.module component. @drpal thanks for script help! :)