On first load of editing, when you click to open, it doesn't take 100% height.

Reproduce:
1. reload page
2. click "Tools"
3. @see below img

tested evn:
- Chrome Windows

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

droplet created an issue. See original summary.

droplet’s picture

Issue tags: +JavaScript
tedbow’s picture

@droplet I can't get this to happen any other conditions that need to happen to make the error show up.

I tried os X, Chrome 60.0.3112.90, Firefox 54.0.1 and Safari 10.1.1

Thanks

droplet’s picture

Title: Make Offcanvas 100% height » Make OffCanvas 100% height on browser has visible scrollbar
Status: Active » Needs review
Issue tags: +Needs manual testing
FileSize
1.55 KB

this is affected by jQuery 3.0 I thought.
https://jquery.com/upgrade-guide/3.0/#breaking-change-outerwidth-or-oute...

When the dialog created, the wrapper set `position: relative;`, the content shifted to the right and has a horizontal scrollbar at page bottom.

+++ b/core/modules/outside_in/js/off-canvas.es6.js
@@ -65,7 +65,8 @@
+      settings.maxHeight = '100%';

this change less relative to this issue but make it 100% is more properly.

drpal’s picture

FileSize
438.37 KB

@droplet This looks good to me. 👍

drpal’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2902299-4.patch, failed testing. View results

Cottser’s picture

drpal’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
1.55 KB

- reroll

drpal’s picture

tedbow’s picture

I still don't see the problem but the latest patch doesn't break anything for me as far as I can tell. Would be good to get more feedback from others as far if they can or can't the problem before the patch.

tedbow’s picture

Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)

tedbow’s picture

Component: settings_tray.module » javascript

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.