On first load of editing, when you click to open, it doesn't take 100% height.

Reproduce:
1. reload page
2. click "Tools"
3. @see below img

tested evn:
- Chrome Windows

CommentFileSizeAuthor
#24 2902299-nr-bot.txt132 bytesneeds-review-queue-bot
#10 2902299-10.patch1.57 KBGrandmaGlassesRopeMan
#9 2902299-8.patch1.55 KBGrandmaGlassesRopeMan
#5 slide.gif438.37 KBGrandmaGlassesRopeMan
#4 2902299-4.patch1.55 KBdroplet
outside-open.png49.92 KBdroplet

Comments

droplet created an issue. See original summary.

droplet’s picture

droplet commented
Issue tags: +JavaScript
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

@droplet I can't get this to happen any other conditions that need to happen to make the error show up.

I tried os X, Chrome 60.0.3112.90, Firefox 54.0.1 and Safari 10.1.1

Thanks

droplet’s picture

droplet commented
Title: Make Offcanvas 100% height » Make OffCanvas 100% height on browser has visible scrollbar
Status: Active » Needs review
Issue tags: +Needs manual testing
StatusFileSize
new 2902299-4.patch1.55 KB

this is affected by jQuery 3.0 I thought.
https://jquery.com/upgrade-guide/3.0/#breaking-change-outerwidth-or-oute...

When the dialog created, the wrapper set `position: relative;`, the content shifted to the right and has a horizontal scrollbar at page bottom. 

+++ b/core/modules/outside_in/js/off-canvas.es6.js
@@ -65,7 +65,8 @@
+      settings.maxHeight = '100%';

this change less relative to this issue but make it 100% is more properly.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
StatusFileSize
new slide.gif438.37 KB

@droplet This looks good to me. 👍

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 2902299-4.patch, failed testing. View results

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue tags: +Needs reroll

Needs reroll, I suspect because of #2902429: Remove previous event handlers when opening new off-canvas block edit form in the off-canvas dialog being committed.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2902299-8.patch1.55 KB

- reroll

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
StatusFileSize
new 2902299-10.patch1.57 KB

- reroll due to #2803375: Rename Outside-in module to "Settings Tray" for real

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

I still don't see the problem but the latest patch doesn't break anything for me as far as I can tell. Would be good to get more feedback from others as far if they can or can't the problem before the patch.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Component: settings_tray.module » javascript

#2784443: Move off-canvas functionality from Settings tray module into drupal.dialog.ajax library so that other modules can use it was committed 🎉! So removing from settings_tray.module component.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
Issue tags: -JavaScript +JavaScript
StatusFileSize
new 2902299-nr-bot.txt132 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

acbramley’s picture

acbramley commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +Bug Smash Initiative, +Needs steps to reproduce

It's not clear to me how to reproduce this, but I tried installing from standard profile on HEAD and enabling the settings_tray module. I then used the quick edit contextual link on several different blocks on the homepage and they were always full height.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since there's been no follow up going to close this one out. If still a valid bug please re-open updating the steps.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.