Problem/Motivation
#2801777: Give users the option to prevent drupal from automatically marking unused files as temporary had a small error in it, and the docblock on FileUsageTemporaryDeletionConfigurationUpdateTest::testUpdateHookN()
is incorrect:
+++ b/core/modules/file/src/Tests/Update/FileUsageTemporaryDeletionConfigurationUpdateTest.php
@@ -0,0 +1,40 @@
+
+ /**
+ * Tests that block context mapping is updated properly.
+ */
This needs to be changed to reflect what the test method is actually doing.
Proposed resolution
Fix the docblock to reflect testing that the before/after make_unused_managed_files_temporary conditions are correct.
Comments
Comment #2
chenderson CreditAttribution: chenderson commentedI am working on this at DrupalCon Vienna
Comment #3
yogen.prasad CreditAttribution: yogen.prasad commentedI am Working on this issue at DrupalCon Vienna 2017.
Comment #4
chenderson CreditAttribution: chenderson commentedComment #5
dinarcon CreditAttribution: dinarcon at Agaric commentedI would remove 'the' before the variable name is the first line of the doc block.
Comment #6
chenderson CreditAttribution: chenderson commentedRemoved the as recommended.
Comment #7
yogen.prasad CreditAttribution: yogen.prasad commentedLooks good :)
Comment #10
Gábor HojtsyGood catch. Committed to 8.5.x and cherry-picked to 8.4.x.