Problem/Motivation

#2801777: Give users the option to prevent drupal from automatically marking unused files as temporary had a small error in it, and the docblock on FileUsageTemporaryDeletionConfigurationUpdateTest::testUpdateHookN() is incorrect:

+++ b/core/modules/file/src/Tests/Update/FileUsageTemporaryDeletionConfigurationUpdateTest.php
@@ -0,0 +1,40 @@
+
+  /**
+   * Tests that block context mapping is updated properly.
+   */

This needs to be changed to reflect what the test method is actually doing.

See also #2801777-111: Give users the option to prevent drupal from automatically marking unused files as temporary .

Proposed resolution

Fix the docblock to reflect testing that the before/after make_unused_managed_files_temporary conditions are correct.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 docblock-on-FileUsageTemporaryDeletionConfigurationUpdateTest-2902190-6.patch919 byteschenderson
#4 docblock-on-FileUsageTemporaryDeletionConfigurationUpdateTest-2902190-4.patch923 byteschenderson

Comments

mpdonadio created an issue. See original summary.

chenderson’s picture

chenderson commented
Issue tags: +Vienna2017

I am working on this at DrupalCon Vienna

yogen.prasad’s picture

yogen.prasad commented

I am Working on this issue at DrupalCon Vienna 2017.

chenderson’s picture

chenderson commented
Status: Active » Needs review
StatusFileSize
new docblock-on-FileUsageTemporaryDeletionConfigurationUpdateTest-2902190-4.patch923 bytes
dinarcon’s picture

dinarcon commented 
+++ b/core/modules/file/tests/src/Functional/Update/FileUsageTemporaryDeletionConfigurationUpdateTest.php
@@ -28,7 +28,9 @@ protected function setDatabaseDumpFiles() {
+   * Tests that the make_unused_managed_files_temporary conditions are correct.

I would remove 'the' before the variable name is the first line of the doc block.

chenderson’s picture

chenderson commented
StatusFileSize
new docblock-on-FileUsageTemporaryDeletionConfigurationUpdateTest-2902190-6.patch919 bytes

Removed the as recommended.

yogen.prasad’s picture

yogen.prasad commented
Status: Needs review » Reviewed & tested by the community

Looks good :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Docblock on FileUsageTemporaryDeletionConfigurationUpdateTest::testUpdateHookN() is incorrect. » Docblock on FileUsageTemporaryDeletionConfigurationUpdateTest::testUpdateHookN() is incorrect
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Good catch. Committed to 8.5.x and cherry-picked to 8.4.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.