Since all the css files for the experimental widget are scss files, we should convert paragraphs.dragdrop.css as well.

CommentFileSizeAuthor
#8 convert-to-scss-2901593-6.patch1.51 KBluksak
#6 convert-to-scss-2901593-5.patch3.49 KBluksak
#2 convert-to-scss-2901593-2.patch3.67 KBluksak

Comments

Lukas von Blarer created an issue. See original summary.

luksak’s picture

luksak
he/him
commented
StatusFileSize
new convert-to-scss-2901593-2.patch3.67 KB

Here it is.

luksak’s picture

luksak
he/him
commented
Status: Active » Needs review
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Structure changed a bit, committed. Looks pretty OK.

+++ b/css/paragraphs.dragdrop.scss
@@ -0,0 +1,81 @@
+.field--widget-paragraphs .field--widget-paragraphs {

I guess this means that we break nested paragraphs if the node has two top level fields currently.

This case is not yet covered and we should likely switch all fields into the drag & drop mode, not only the one field where you click with its children. In fact, drag & drop across top level fields is likely a wanted feature as well.
Created follow-up for the full drag & drop: #2901601: Apply drag & drop mode to all top level fields

luksak’s picture

luksak
he/him
commented
Status: Fixed » Needs review
StatusFileSize
new convert-to-scss-2901593-5.patch3.49 KB

Status: Needs review » Needs work

The last submitted patch, 6: convert-to-scss-2901593-5.patch, failed testing. View results

luksak’s picture

luksak
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new convert-to-scss-2901593-6.patch1.51 KB

Should apply now.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Aaand committtted :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.