In the English language Post as name of content-type and Post as verb for "to publish" is the same.

#6

But it other languages that's not the case.

f.e. If I would translate the name for content-type it would be something like "Beitrag" and if I would translate the verb it would be something like "veröffentlichen" - two absolutly different words.

What currently happens with only one available translation for "post" is:

#7

That's confusing for users ...

CommentFileSizeAuthor
#5 post-button-string-2901337-5.patch866 bytesslowflyer
#3 social_post_module.patch857 bytesslowflyer
Clipboard07.jpg10.4 KBslowflyer
Clipboard06.jpg10.75 KBslowflyer

Comments

slowflyer created an issue. See original summary.

fraganda’s picture

fraganda commented
Related issues: +#2891575: add translation context to Post button

See also issue:2891575

slowflyer’s picture

slowflyer commented
StatusFileSize
new social_post_module.patch857 bytes

Attached my suggestion to solve it.

maikelkoopman’s picture

maikelkoopman commented

Hi @slowflyer, thanks for submitting the patch. I think it is better to use the String context and not put markup in the translatable string. https://www.drupal.org/node/1369936 explains it. Maybe you can have a look at this and create a patch based on this method? Could you also upload a patch with the correct name like short-description-issueID-commentnumber (eg. post-button-string-2901337-4)? Thank you very much.

slowflyer’s picture

slowflyer commented
StatusFileSize
new post-button-string-2901337-5.patch866 bytes

Thanks for the hint!

Here it is ...

slowflyer’s picture

slowflyer commented
Status: Active » Needs review
maikelkoopman’s picture

maikelkoopman commented
Assigned: Unassigned » maikelkoopman
maikelkoopman’s picture

maikelkoopman commented
Status: Needs review » Reviewed & tested by the community

Thanks slowflyer, I have reviewed and tested it. Will merge it soon, after behat tests have passed.
Pull request: https://github.com/goalgorilla/open_social/pull/506

maikelkoopman’s picture

maikelkoopman commented
Status: Reviewed & tested by the community » Fixed

will be part of release 1.4

  • maikelkoopman authored 4ea6854 on 8.x-1.x 
    Merge pull request #506 from goalgorilla/feature/2901337-post-...
  • maikelkoopman committed 5a8020a on 8.x-1.x
    Issue #2901337 by maikelkoopman, slowflyer: Add context for post button...
FleurJ’s picture

FleurJ commented

Great, thank you!

is it possible to do the same for "comment" ? In french the name and the verb are not the same too?

(I can create a new issue if necessary)

maikelkoopman’s picture

maikelkoopman commented

@FleurJ If possible can you create a new issue with the patch there. I think you can use this issue's patch as an example. Bonus points if you can also create a pull request with the change here: https://github.com/goalgorilla/open_social ;). That will save us some time.

FleurJ’s picture

FleurJ commented

ok, I can create the new issue. I never did a pull request, I can try too :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.