Theme is not loading

Same problem here. This is definitely a bug in the theme. That's a pity, this theme is really nice.

Hello,

I tried fixing some bugs in the Professional Theme - 8.x , I am working on menus part they are not responsive yet.
But rest of the part is done.

Please find the updated version of theme attached.
Kindly try the same & let me know if any problem persists, so that I could fix that too.

Hope that helps!

Thanks & Regards,
Deepika Chavan

Hello,

I fixed the menu bar.
Please find the attached updated and working theme.
Kindly try the same & let me know if any problem persists.

Thanks & Regards,
Deepika Chavan

Seems to work nice, great job! :)

A few problems I found so far:
1) The first slide image is not replaced by the one I chose in the parameters. Slides #2 and #3 are correctly displayed, though.
2) Links in the page footer (first/second/third bottom) are hard to read (blue on dark grey). I suggest to use a lighter blue for these links, or even light grey. What do you think?
3) The template uses class="site-name" but the CSS contains #site-title. You must use |h1 id="site-title"| in block--system-branding-block.html.twig.
4) The .form-text CSS class lacks a |display: block;| to correctly display forms.

Also, is the current content of the css/ directory needed, or can it be removed entirely? I think style.css should be moved there instead of being in the root directory.

Hi LpSolit,

Thanks for the feedback, much appreciated. I will try to fix that asap.

Regards,
Deepika Chavan

Hi LpSolit,

I worked on following points:
1) The first slide image is not replaced by the one I chose in the parameters. Slides #2 and #3 are correctly displayed, though.
- Fixed
2) Links in the page footer (first/second/third bottom) are hard to read (blue on dark grey). I suggest to use a lighter blue for these links, or even light grey. What do you think?
- Done
3) The template uses class="site-name" but the CSS contains #site-title. You must use |h1 id="site-title"| in block--system-branding-block.html.twig.
- Done
4) The .form-text CSS class lacks a |display: block;| to correctly display forms.
- Done
5)Also, is the current content of the css/ directory needed, or can it be removed entirely? I think style.css should be moved there instead of being in the root directory.
- Moved the style.css inside /css folder. Also I am not sure about the content of /css/scss folder, I guess, we can remove that. But I thought I should check with theme author.

Please find the updated theme folder attached.

Thanks & Regards,
Deepika Chavan

@Deepika.chavan,

Great job. In my option your work could be incorporate in 8.x branch, so others developers can contribute too.
Could you send your changes as git patch? I can do it for you if you want.

@thiagogomesverissimo,

Thanks. Please find the attached patch file for all the changes.
Also I took logo, favicon & screenshot images from 7.x folder of the theme, so need to replace that too.
Kindly try the patch & let me know if any problem persists.

Thanks & Regards,
Deepika.chavan,

@Deepika.chavan,

The patch did not work, see the printscreens below.

Errors:

error: patch failed: professional_theme.info.yml:1
error: professional_theme.info.yml: patch does not apply

@thiagogomesverissimo,

May be because you are trying to apply patch from the professional_theme folder.
Try running that same command from /drupal/themes/. folder.

I applied same patch using following command locally it worked,
patch -p0 -b < professional_theme_8-x.patch

@Deepika.chavan,

I think "patch -p0 -b" is an older way to handle patches, drupal now uses git.

Did you generate your patch from 8.x-1.x branch?
I saw you used two different folder (professional_theme_working and professional_theme) to do diff, but the recommend way is to use branches.

The following workflow should works for everyone, but it is not:

git clone --branch 8.x-1.x https://git.drupal.org/project/professional_theme.git
cd professional_theme
wget https://www.drupal.org/files/issues/2018-04-24/professional_theme_8-x.patch
git apply -v professional_theme_8-x.patch

However, answering your question, yes, using patch -p0 -b, it worked, with one exception:

Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file professional_theme/professional_theme.info.yml.rej

By the way,

+1 to this patch to be incorporated into branch 8.x

@thiagogomesverissimo,

Sorry my bad, I was not aware about the second method i.e. git.
So I did diff between professional_theme(8.x-1.3) & my working theme directory & created that patch.

I guess you are getting below error because in 1st attempt when you were trying to apply patch from inside professional_theme/ folder, that time some changes might had happened (as per #15). Correct me if I am wrong.

Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file professional_theme/professional_theme.info.yml.rej 

Thanks for testing, next time I will use git to create patch :)

Regards,
Deepika Chavan

I tested the offical D8 version and found it is not functional at all (block layout can be defined, but is not resolved).
Will there be a fully functional version after nearly 2 years of no new version?
I hope the work of Deepika Chavan willl lead to a new offical version since migrating the theme is one issue on our long list for migrating to D8

yes, the @Deepika.chavan's patch should be released.

How do I get a copy of the working patch?

Patch #13, is no more working on Drupal 8.

Adding needs reroll tag.