Just upgraded several sites to 1.17 and now when I scroll down the page, the "We use cookies ..." message disappears. Clearing the cache doesn't make any difference on it's own. The configuration doesn't have "Consent by scrolling" ticked.
To get round the issue, saving the configuration without making any changes and then clearing the cache returns behaviour back to normal i.e. scrolling doesn't make the message disappear.
The sites that have issues all use a sub-theme of Zen - all the sites have been using EU Cookie Compliance for a long time without issues. A site that uses a sub-theme of Bootstrap works fine.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | eu-cookie-compliance-scrolling-consent-2900347-9.patch | 940 bytes | svenryen |
Comments
Comment #2
svenryen commentedHi @benqwerty! Really sorry to hear you're having trouble with version 1.17. The module has been tested, but not with subthemes of Zen.
What version did you upgrade from?
Did it help to re-save the configuration when you saw this issue?
I tried upgrading from 7.14 to 7.17, and didn't see your problem when the site was running Bartik (I realize Bartik is not a good use case, but there's limited time available for this volunteer work and I can't test the module with every single theme out there..)
Comment #3
svenryen commentedAnd one more thing: What happens when you run this in your browser console?
Drupal.settings.eu_cookie_compliance.popup_scrolling_confirmationComment #4
svenryen commentedI went to download the Zen theme, then realized it has multiple versions available. What version of the Zen theme are you using, Ben?
Comment #5
svenryen commentedI've tried doing the following:
1) Set up a site with a Zen 7.x-6.4 sub theme
2) Reset the database and cookies
3) Install EU Cookie Compliance 1.14
4) Update to EU Cookie Compliance 1.17
5) Run update.php
6) Load the page in the browser and try scrolling
What I saw here was that even while scrolling, the popup banner was not dismissed.
I could not reproduce the issue where scrolling in a Zen subtheme dismissed the banner. I'm clearly missing something here, so I hope you can help me with more details.
Comment #6
benqwerty commentedThanks for the quick response.
I can see the issue when upgrading from 7.14 to 7.16, 7.14 to 7.17 and 7.16 to 7.17.
Saving the configuration stops the issue but I think that might come back again on the next upgrade - I'll double check that.
Before the upgrade Drupal.settings.eu_cookie_compliance.popup_scrolling_confirmation is undefined. After the upgrade it's set to true (even though the checkbox isn't selected).
I'm using Zen version 7.x-5.6.
Comment #7
svenryen commentedThanks, I'll try with Zen 5.6. And one more question: What version of jQuery is your site running?
Comment #8
benqwerty commentedI've just checked and I get the same thing with Bartik. Running jQuery 1.7.
Comment #9
svenryen commentedLooking at the source, the default for scrolling was indeed TRUE. Nice catch! I was tricked by not wiping out the `variable_store` table when I tested earlier.
Can you see if this patch fixes your issue? If it does, please mark this issue "Reviewed and Tested by the community" so that we can add it to the dev branch.
Comment #10
benqwerty commentedThat's great, thank you!
I tested it before the "Consent by scrolling" checkbox had been set, with it checked and then with it un-checked. Everything seems to be working fine.
Thanks again!
Comment #12
svenryen commentedCommitted to -dev. Thanks a lot!