The "Stock Locations" link is not positioned correctly on the {site}/admin/commerce page.

The "Configuration" link should always be the last link on the {site}/admin/commerce page, but it is not after installing commerce stock.

CommentFileSizeAuthor
#10 Screenshot 2017-10-24 15.20.39.png48.42 KBguy_schneerson
#5 d8-commerce-layout-problem-status-report-0001.png119.1 KBwebsiteworkspace
#5 d8-commerce-layout-problem-commerce-config-0001.png99.39 KBwebsiteworkspace
#5 d8-commerce-layout-problem-commerce-0001.png73.37 KBwebsiteworkspace
#5 d8-commerce-layout-problem-stock-modules-installed-0001.png135.2 KBwebsiteworkspace

Comments

DrupalWebsiteBuilder created an issue. See original summary.

websiteworkspace’s picture

websiteworkspace commented
Issue summary: View changes
guy_schneerson’s picture

guy_schneerson commented

Thanks DrupalWebsiteBuilder for reporting.

olafkarsten’s picture

olafkarsten commented
Status: Active » Closed (cannot reproduce)

@DrupalWebsiteBuilder Unfortunately I cannot reproduce the issue. Did you enable the submodule commerce_stock_local?
On a fresh d8 / commerce2 install the link is where it should be. Feel free to reopen and provide steps to reproduce the issue.

websiteworkspace’s picture

websiteworkspace commented
StatusFileSize
new d8-commerce-layout-problem-stock-modules-installed-0001.png135.2 KB
new d8-commerce-layout-problem-commerce-0001.png73.37 KB
new d8-commerce-layout-problem-commerce-config-0001.png99.39 KB
new d8-commerce-layout-problem-status-report-0001.png119.1 KB

Problem reported above still exists today.
Updated via composer update to latest versions of all core, commerce, module, versions.

1. image of admin/extend page shows stock modules installed
2. image of admin/commerce, latest today (all caches clear to be up to date)
- Stock Locations link in wrong order (should alphabetic but with configuration at the bottom)
3. image of admin/commerce/config
- stock location types link section NOT in alphabetical order
4. image of status report (notes pathauto entity problem reported in commerce bug report previously)

stock location link problem

config links problem

websiteworkspace’s picture

websiteworkspace commented
Status: Closed (cannot reproduce) » Active
olafkarsten’s picture

olafkarsten commented
Issue tags: +Config novice

Okay, understand the issue now. Thanks for taking the time to clarify.

We need to remove the weight definition in commerce_stock_local.links.menu.yml. Beside that we should group all stock configuration links under a stock group, like the rest of the commerce configuration admin page. Good example how to do that is commerce_order.links.menu.yml

guy_schneerson’s picture

guy_schneerson commented

Thank you both :) @olafkarsten have you got time/fancy writing a PR for this?

  • guy_schneerson committed a7578a5 on 8.x-1.x 
    Issue #2900254 by DrupalSiteBuilder, guy_schneerson, olafkarsten: stock...
guy_schneerson’s picture

guy_schneerson commented
Status: Active » Fixed
StatusFileSize
new Screenshot 2017-10-24 15.20.39.png48.42 KB

cleaned up the menu - all stock related items are now grouped commerce menu

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.