To enable the exclusion of tracking private files in Piwik, we need the link to private files in webforms te have an unique class to identify them.

CommentFileSizeAuthor
#12 interdiff.patch890 bytespaulvandenburg
#12 class_for_encrypted_files-2899832-12.patch2.77 KBpaulvandenburg
#9 class_for_encrypted_files-2899832-9.patch2.75 KBjoshahubbers
#7 class_for_encrypted_files-2899832-7.patch1.26 KBjoshahubbers
#5 class_for_encrypted_files-2899832-3.patch830 bytesaskibinski
#2 class_for_encrypted_files-2899832-2.patch829 bytesjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new class_for_encrypted_files-2899832-2.patch829 bytes
joshahubbers’s picture

joshahubbers commented
Assigned: joshahubbers » Unassigned
Status: Active » Needs review
askibinski’s picture

askibinski commented
Status: Needs review » Needs work

Comment needs to start with a capital and end with a dot. Otherwise looks good to me.

askibinski’s picture

askibinski commented
Status: Needs work » Needs review
StatusFileSize
new class_for_encrypted_files-2899832-3.patch830 bytes
askibinski’s picture

askibinski commented
Status: Needs review » Needs work

Also, class needs to be set on preview link (visible after uploading a file by ajax).

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new class_for_encrypted_files-2899832-7.patch1.26 KB

ef file check added to _dvg_media_file_types_file_link. This function is overwritten in normal page display, so the class will not be added there, but is added after the ajax file upload is done.

askibinski’s picture

askibinski commented
Status: Needs work » Reviewed & tested by the community

Allright, looks good!

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new class_for_encrypted_files-2899832-9.patch2.75 KB

Changed the patch. Now the link encrypted file is added alongside the link-file class. Piwik tracks the file anyway. With this patch the file is either with class encrypted file or class link-file.

CSS changed to duplicate styling of link-file to encrypted-file.

joshahubbers’s picture

joshahubbers commented
Status: Reviewed & tested by the community » Needs review
ruudvanoijen’s picture

ruudvanoijen commented
Status: Needs review » Needs work

The patch fails the drupal coding standards.

paulvandenburg’s picture

paulvandenburg commented
Status: Needs work » Needs review
StatusFileSize
new class_for_encrypted_files-2899832-12.patch2.77 KB
new interdiff.patch890 bytes

The coding standards issues are the if else formatting.
Fixed those.

askibinski’s picture

askibinski commented
Status: Needs review » Reviewed & tested by the community

Looks good. Essentially the patch only adds a class which needs to be used by custom code and is safe to commit.

  • askibinski committed c60c262 on 7.x-1.x 
    Issue #2899832 by JoshaHubbers: Add class to encrypted file link
askibinski’s picture

askibinski commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.