`quote` should be `blockquote` in off-canvas.base.css

Replaced quote with blockquote.

Good catch!

I think we should postpone this on #2784443: Move off-canvas functionality from Settings tray module into drupal.dialog.ajax library so that other modules can use it, which should land before beta. This simple tiny bugfix can go in at any time.

Thank you very much though, it'll definitely be committed later!

Changing to new settings_tray.module component. @drpal thanks for script help! :)

@gaurav.kapoor thanks for updating the patch since the module machine name has changed. If you could leave comment as to why you are updating the patch that would be helpful.

Also I think it would need to go back to "Needs Review" at that point.

The patch doesn't apply because the off-canvas portion of Settings Tray has been moved to /core/misc/dialog since #2784443: Move off-canvas functionality from Settings tray module into drupal.dialog.ajax library so that other modules can use it

So it will need to update there though. Also there will be copy of the affected file in Stable theme that will also need to be updated.

@tedbow . I was having some network issues, I wasn't sure my patch got uploaded or not.
I created patch for 8.4.x as that's the release tagged with this issue.
I will do changes in 8.5.x and upload the patch again.
Thanks.

@gaurav.kapoor sorry didn't notice the issue was still against 8.4.x.

I changed it to 8.5.x since this type of change should always go against the current development branch(i am pretty sure)

Changed both instances of #drupal-off-canvas quote in 8.5.x branch.

@gaurav.kapoor look great!

Changing the title since this is no longer a question and removing "[PP-1]" which indicates that it was postponed on 1 other issue, #2784443: Move off-canvas functionality from Settings tray module into drupal.dialog.ajax library so that other modules can use it

Forgot also this is not part of the Settings Tray module anymore

Nice catch!

Committed and pushed to 8.5.x and cherry-picked to 8.4.x since it's a straight-up bug fix.

...is what she said, before she actually applied the patch to 8.4.x. :D

Can we get a quick re-roll for 8.4.x?

Did a reroll for 8.4.x.

This is an interdiff of last two patches.

@gaurav.kapoor,

Your patch looks good and it worked well on Drupal-8.4.x.

Committed as b84e81c and pushed to 8.4.x.

@Venkatesh Rajan.J, please don't paste screenshots of patches applied, we have automated testing for that.