Follow-up to #1203532: jQuery Form Plugin update to latest stable release

Problem/Motivation

jQuery.form got new home so changed it's major version https://github.com/jquery-form/form/releases

https://github.com/jquery-form/form/releases/tag/v4.2.0 points that 4.2.0

jQuery Form is confirmed to be compatible with jQuery 2 and 3!

So for 8.4.0 core it should be updated to be sure that nothing will be broken

Proposed resolution

Update to latest stable release

Remaining tasks

patch, review, commit

User interface changes

no

API changes

no

CommentFileSizeAuthor
#9 jquery_form_plugin-2899141-9.patch32.49 KBjohnchque
#5 2899141-jq-form-5.patch32 KBandypost
#5 interdiff-2899141-3.txt514 bytesandypost
#3 2899141-jq-form-2.patch31.99 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Category: Bug report » Task

+1 to doing this. Good to keep our vendor libraries updated whenever possible.

https://github.com/jquery-form/form/releases/tag/v4.2.0 says "jQuery Form is confirmed to be compatible with jQuery 2 and 3!", which is great news. It does not explicitly say that previous versions were not compatible with jQuery3, so recategorizing this issue from bug to task. However, if someone finds a bug with HEAD's jquery.form, or an explicit mention on the jquery-form project that discusses one, then at that time, please set this back to a bug.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Active » Needs review
Parent issue: #1203532: jQuery Form Plugin update to latest stable release » #2533498: Update jQuery to version 3
Related issues: +#1203532: jQuery Form Plugin update to latest stable release
FileSize
2899141-jq-form-2.patch31.99 KB

Here's initial patch

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue summary: View changes

@effulgentsia thanks, fixed summary

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#2897837: Change the links on core.libraries.yml licenses so they link to the licenses themselves
FileSize
interdiff-2899141-3.txt514 bytes
2899141-jq-form-5.patch32 KB

Licence should point to the file according related #2897837: Change the links on core.libraries.yml licenses so they link to the licenses themselves

kwoxer’s picture

kwoxer CreditAttribution: kwoxer commented

I had a look on this. But I just wondered why there is a patch for 4.2.1 instead of the latest 4.2.2 Version. (https://github.com/jquery-form/form/releases)

So I would say we should take this version on a new patch here, instead of fixing this one and opening a new issue in some weeks. WDYT?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Needs work

@kwoxer good catch, please file a patch with 4.2.2 version https://github.com/jquery-form/form/releases/tag/v4.2.2

NW for new patch

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
CreditAttribution: johnchque commented
Status: Needs work » Needs review
FileSize
jquery_form_plugin-2899141-9.patch32.49 KB

Using version 4.2.2. :)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

Tested the patch to improve our UX in Paragraphs to avoid false change detection when collapsing unchanged form items. Works very well.
I'd vote to also apply this to the current stable as a bugfix.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

Call to action! :-)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: jquery_form_plugin-2899141-9.patch, failed testing. View results

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs work » Reviewed & tested by the community

That was an infra error.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Issue tags: +Contributed project blocker

  • catch committed c7833e3 on 8.6.x 
    Issue #2899141 by andypost, yongt9412: jQuery Form Plugin update to...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

Committed/pushed to 8.6.x, thanks!

This missed the window for 8.5.0 beta, not sure about backporting there so leaving RTBC against that branch for now.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Version: 8.5.x-dev » 8.6.x-dev
Status: Reviewed & tested by the community » Fixed

Given that we're only a few days away from 8.5.0's release, and our JS testing harness is not as robust as we'd like, there was agreement to keep this in 8.6.x only. However, maybe a workaround for 8.5.0 could be a 'jQuery Form Update' module. ;)

Chi’s picture

Chi CreditAttribution: Chi commented

Followup: #2951787: Add missing jquery.form.min.js.map file.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.