With #2871910: Standardize on DrupalDefaultEntityController, VersioncontrolGitEventController::attachExtendedEventData() now happens after VersioncontrolGitEvent::build().

VersioncontrolGitEvent::build() no longer has refs to construct at that time.

CommentFileSizeAuthor
#7 2899121.patch702 bytesdrumm
#4 2899121.patch2.59 KBdrumm
#2 2899121.patch2.59 KBdrumm

Comments

drumm created an issue. See original summary.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Needs review
StatusFileSize
new 2899121.patch2.59 KB

This patch collapses ref object construction into VersioncontrolGitEventController::attachExtendedEventData().

And also uses PDO::FETCH_ASSOC to save an object to array conversion.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Needs work

This did not work well with thorough testing.

drumm’s picture

drumm
he/him
Location NY, US
commented
Project: Version Control API -- Git backend » Version Control API
Component: Code » API - Entity Controllers
Status: Needs work » Needs review
StatusFileSize
new 2899121.patch2.59 KB

This patch restores the order of those functions being called by running attachExtendedEventData() earlier.

drumm’s picture

drumm
he/him
Location NY, US
commented
Title: Keep up with versioncontrol changes » Attach extended data earlier in event loading

Status: Needs review » Needs work

The last submitted patch, 4: 2899121.patch, failed testing. View results

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs work » Needs review
StatusFileSize
new 2899121.patch702 bytes

Uploading the correct patch.

The last submitted patch, 2: 2899121.patch, failed testing. View results

  • marvil07 committed c89e870 on 7.x-1.x authored by drumm 
    Issue #2899121 by drumm: Attach extended data earlier in event loading
marvil07’s picture

marvil07 commented
Status: Needs review » Fixed

Good catch!

Interestingly enough, I could verify a test was failing on versioncontrol_git, which I forgot to run after #2871910: Standardize on DrupalDefaultEntityController. Now I see all the versioncontrol_git tests passing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.