On line 33 of `eu_cookie_compliance.js` you have a very obvious error where you're binding the click function that hides the cookie banner only if the option "Click to confirm" is NOT set. This should be reversed, so that the script reflects what's been configured in the admin interface.

CommentFileSizeAuthor
#9 eu-cookie-compliance-banner-behavior-opposite-2899095-9.patch1.29 KBsvenryen
#2 eu-cookie-compliance-banner-behavior-opposite-2899095-2.patch519 bytessvenryen

Comments

svenryen created an issue. See original summary.

svenryen’s picture

svenryen commented
StatusFileSize
new eu-cookie-compliance-banner-behavior-opposite-2899095-2.patch519 bytes

This patch fixes the issue.

svenryen’s picture

svenryen commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: eu-cookie-compliance-banner-behavior-opposite-2899095-2.patch, failed testing. View results

svenryen’s picture

svenryen commented

I removed one character from a Javascript and the tests fail. Clearly this failure is not related to the patch I created. If we can't have proper tests for this module, I suggest we just remove the tests, since it probably takes less time to test such a simple module manually compared to the time it takes to maintain a test suite.

agoradesign’s picture

agoradesign commented

Should we include an update script that reverses the value?

Because assuming one hasn't used that patch so far, the solution to get the expected behaviour is to simply configure this variable to the opposite of the intented meaning

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented

Sounds good idea. I would indeed assume People did not use the patch and this reverse the value in An update hook. I think we may assume People who patched check the release notes to see they need to rereverse the value.

agoradesign’s picture

agoradesign commented

@mallezie: absolutely agree. Everyone using a certain patch should normally know, that the patch content's and other things can change until it gets committed. Also using dev/alpha/beta versions and updating them needs some extra attention. Of course this change should get an extra mention in the release notes, as well creating a change record would be nice

svenryen’s picture

svenryen commented
StatusFileSize
new eu-cookie-compliance-banner-behavior-opposite-2899095-9.patch1.29 KB

Here's a patch that fixes the issue and also provides an update hook to reverse the setting.

  • svenryen committed 0ce110a on 8.x-1.x 
    Issue #2899095 by svenryen: Banner behaviour for "Consent by clicking"...
svenryen’s picture

svenryen commented
Status: Needs work » Fixed
svenryen’s picture

svenryen commented
Status: Fixed » Closed (fixed)