We use multiple sendgrid API keys from within one Drupal instance and I'd like to be able to use the results of sendgrid_integration_reports_get_stats with each of them. I'm hoping to add $key_secret = NULL to the function declaration to facilitate this. Patch forthcoming.

CommentFileSizeAuthor
#9 multi_key_reporting-2899019-4.patch5.49 KBlambic
#3 multi_key_reporting-2899019-3.patch4.4 KBmirabuck
#2 multi_key_reporting-2899019-2.patch1.75 KBmirabuck

Comments

Mirabuck created an issue. See original summary.

mirabuck’s picture

mirabuck commented
Assigned: mirabuck » Unassigned
Status: Active » Needs review
StatusFileSize
new multi_key_reporting-2899019-2.patch1.75 KB

Patch attached.

mirabuck’s picture

mirabuck commented
StatusFileSize
new multi_key_reporting-2899019-3.patch4.4 KB

Updated patch to handle all reporting functions.

perignon’s picture

perignon commented

Thanks for the contribution. I'll review it tonight!

perignon’s picture

perignon commented
Assigned: Unassigned » perignon
perignon’s picture

perignon commented

Queued test.

  • Perignon committed 933adc2 on 7.x-1.x authored by Mirabuck 
    Issue #2899019 by Mirabuck: Allow report function to be called with...
lambic’s picture

lambic commented

I'm rerolling this patch, there are some caching issues.

lambic’s picture

lambic commented
StatusFileSize
new multi_key_reporting-2899019-4.patch5.49 KB

Here's the new patch.

  • Perignon committed 6bbcd24 on 7.x-1.x authored by lambic 
    Issue #2899019 by Mirabuck, lambic: Allow report function to be called...
perignon’s picture

perignon commented

Just pushed!

perignon’s picture

perignon commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.