When you visit your site via HTTPS you can see an error because there are mixed contents. Since Google CSE module use http in form action.

CommentFileSizeAuthor
#5 fix_url_protocol-2898998-5.patch1.88 KBrromore
#2 avoid-mixed-contents-2898998-2.patch1.39 KBasrob
skitch (24).png64.1 KBasrob

Comments

asrob created an issue. See original summary.

asrob’s picture

asrob
he/him
Primary language Hungarian
Location Hungary 🇭🇺 🇪🇺
commented
StatusFileSize
new avoid-mixed-contents-2898998-2.patch1.39 KB

Attached a small patch to change from http to https.

afinnarn’s picture

afinnarn commented

Hey @asrob, thanks for the patch!

Can you try to make the link protocol relative? I've seen mixed advice about that being best practice or being an anti-pattern, but the opposite would be true if you change to HTTPS and visit your site in HTTP mode. For this resource, I don't think security is much of a concern if it is fetched over HTTP sometimes.

afinnarn’s picture

afinnarn commented
Status: Needs review » Needs work
rromore’s picture

rromore commented
StatusFileSize
new fix_url_protocol-2898998-5.patch1.88 KB

Attaching a patch which determines the correct protocol to use.

rromore’s picture

rromore commented
Status: Needs work » Needs review
twfahey’s picture

twfahey commented

Awesome work, @rromore. We will be incorporating your work here in a related issue - https://www.drupal.org/project/google_cse/issues/2948111, will be sure to get you credit for the fix.

  • twfahey committed 1acdacc on 8.x-3.x 
    Issue #2948111 by mark_fullmer, twfahey, xeM8VfDh, afinnarn, jwest1@...
twfahey’s picture

twfahey commented
Status: Needs review » Fixed
twfahey’s picture

twfahey commented
Status: Fixed » Closed (fixed)