Closed (works as designed)
Project:
Clientside Validation
Version:
8.x-1.x-dev
Component:
Documentation
Priority:
Major
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
1 Aug 2017 at 02:23 UTC
Updated:
4 Apr 2023 at 07:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
nikunjkotechaComment #4
nikunjkotechaFix for build failure and additional fix to allow other modules to destroy validator using objects stored in Drupal.cvValidatorObjects.
Comment #6
nikunjkotechaComment #7
nikunjkotechaComment #9
nikunjkotechaRemoved the changed related to composer.json inside module. This will be handled separately in https://www.drupal.org/node/2784069 or some other ticket.
Comment #10
jelle_sI'm not sure we need this functionality?
Developers can add their own submit handler to their forms in their js files like this:
Comment #11
nikunjkotecha@Jelle_S It was not updating after it's initiated once
Comment #12
jelle_sAh, strange. I'll try to create a proof of concept later on. If I can get it to work fairly simple, I'll add the method to the readme. If not, I'll have another look at the patch.
Comment #13
nikunjkotechaI think if we only add Drupal.cvValidatorObjects or something to store all objects, it would allow other modules to modify settings. Submit handler being more common case I added in module js itself.
Comment #14
jelle_sAttached is a proof of concept that works for me (latest dev version of clientside validation 8.x-1.x. Can you confirm it works for you too?
If it does we might want to document this.
Comment #15
nikunjkotecha@Jelle_S this works fine, I'll spend sometime tonight to create a documentation page from the code sample you shared :)
I see where I was missing, I was trying to use validate() with options again to bind the submit function.
Comment #16
nikunjkotecha