Looking at 7.x-1.16 on a test site, I see the new option to restrict the popup to certain countries - either by source PHP, or at a javascript level. Nice. Particularly the latter, which avoids paying a price on caching.

When I hover over those two checkboxes, the following explanation is displayed:

If you want to limit the number of countries for which the cookie is displayed, you can place an array in $conf[\'eu_cookie_compliance_eu_countries\'] in your settings.php. Using the geoip module or the smart_ip module or the geoip_country_code_by_name() PHP function.

I took that to mean that I had to create such an entry in my settings.php file. So I started to do so, only to realise I didn't know exactly what format it needed to have (2 character ISO country codes, 3 character, or ...).

So I searched the code to see how it uses the array ... to find that there is a sensible default that sets the array to all EU countries, or "null".

So may I request that this admin screen tooltip is altered to make clear that:

You can limit the number of countries for which the warning is displayed by checking this option. If you want a list of countries other than current EU states, you may place an array in $conf[\'eu_cookie_compliance_eu_countries\'] in your settings.php.

(I also changed "cookie" to "warning" - it's not strictly the cookie that is displayed in the popup)

Comments

JamesOakley created an issue. See original summary.

svenryen’s picture

Thanks a lot! I committed this change to -dev, I hope you're okay that I called it "banner" and not "warning". While we're at it, do you see any other strings in the admin form that can be improved to further clarify intent and message?

jamesoakley’s picture

Status: Active » Fixed

Thanks - that was fast!

"Banner" is fine, and is consistent with your other admin strings.

I've looked down the rest of the admin UI, at both labels and tooltips, and I think everything else is clear. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.