CommentFileSizeAuthor
#36 2898234-36-WIP.patch21.54 KBguilhermevp
#29 2898234-29-WIP.patch41.98 KBguilhermevp
#24 office_hours_2898234-24_codingstandard.patch17.92 KBjohnv
#16 office_hours-coding-standarts-2898234-16.patch1.08 KBecho15
#6 apply_coding_standards_2898234_5.patch9.23 KBvdenis
#4 apply_coding_standards_2898234_4.patch3 KBvdenis

Comments

johnv created an issue. See original summary.

  • johnv committed 50f9c5f on 8.x-1.x 
    Issue #2898234: Apply coding standards
johnv’s picture

johnv
Primary language Dutch
commented
Priority: Normal » Minor
vdenis’s picture

vdenis commented
StatusFileSize
new apply_coding_standards_2898234_4.patch3 KB

Providing patch.

vdenis’s picture

vdenis commented
Status: Active » Needs review
vdenis’s picture

vdenis commented
StatusFileSize
new apply_coding_standards_2898234_5.patch9.23 KB

Providing new patch with additional coding standards fixes in OfficeHoursDateHelper.php

echo15’s picture

echo15 commented
Status: Needs review » Reviewed & tested by the community

Patch applied locally. Looks good!
Thanks for the fix.

  • johnv committed bb0a45b on 8.x-1.x authored by denisveg 
    Issue #2898234 by denisveg: Apply coding standards
johnv’s picture

johnv
Primary language Dutch
commented
Status: Reviewed & tested by the community » Active

Committed. Thanks. Leaving this open for later changes.

  • johnv committed 392fd79 on 8.x-1.x 
    Issue #2898234: Apply coding standards: OfficeHoursSlot.php
  • johnv committed e1734a9 on 8.x-1.x
    Issue #2898234: Apply coding standards: OfficeHoursList.php

  • johnv committed f131520 on 8.x-1.x 
    Issue #2898234: Apply coding standards: OfficeHoursFormatterSchema.php

  • johnv committed 852088e on 8.x-1.x 
    Issue #2898234: Apply coding standards: OfficeHoursFormatterTable.php

  • johnv committed 3bf5bbb on 8.x-1.x 
    Issue #2898234: Apply coding standards: use ->t()

  • johnv committed 09f68f3 on 8.x-1.x 
    Issue #2898234: Apply coding standards: use ->t() / restore file
echo15’s picture

echo15 commented
Issue tags: +epam-contrib-2019.03
echo15’s picture

echo15 commented
StatusFileSize
new office_hours-coding-standarts-2898234-16.patch1.08 KB

Providing new patch with additional coding standards fixes

echo15’s picture

echo15 commented
Status: Active » Needs review
nikolas.tatianenko’s picture

nikolas.tatianenko commented
Status: Needs review » Reviewed & tested by the community

  • johnv committed 7af5eff on 8.x-1.x 
    Issue #2898234 by echo15, johnv: Apply coding standards
johnv’s picture

johnv
Primary language Dutch
commented
Status: Reviewed & tested by the community » Active

Thanks, committed , together with some 'clean code' changes.
Back to active.

  • johnv committed 58c0260 on 8.x-1.x 
    Issue #2898234: Apply coding standards

  • johnv committed 39d1be0 on 8.x-1.x 
    Issue #2898234: Apply coding standards office_hours.views.inc

  • johnv committed 0ae7d4f on 8.x-1.x 
    Issue #2898234: Apply coding standards: t() in OfficeHoursItemList.php
johnv’s picture

johnv
Primary language Dutch
commented
Assigned: johnv » Unassigned
Status: Active » Needs review
Issue tags: -epam-contrib-2019.03
StatusFileSize
new office_hours_2898234-24_codingstandard.patch17.92 KB

  • johnv committed bd58fd4 on 8.x-1.x 
    Issue #2898234: Apply coding standards
johnv’s picture

johnv
Primary language Dutch
commented
Version: 8.x-1.x-dev » 8.x-1.2
Status: Needs review » Active
johnv’s picture

johnv
Primary language Dutch
commented
Version: 8.x-1.2 » 8.x-1.x-dev
guilhermevp’s picture

guilhermevp commented
Assigned: Unassigned » guilhermevp
guilhermevp’s picture

guilhermevp commented
Assigned: guilhermevp » Unassigned
Status: Active » Needs work
StatusFileSize
new 2898234-29-WIP.patch41.98 KB

I started a patch with some changes, but is not completely clean, There is some work to be done yet, and something to decide that I believe are up to the maintainers.

johnv’s picture

johnv
Primary language Dutch
commented

I explicitely do not adhere to some of the code requirement, such as 'max 80 characters' and 'No inline comment behind code'.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs work » Active

Thanks @guilhermevp, I committed most of your patch.
You were fast. Do you have some kind of tool?

guilhermevp’s picture

guilhermevp commented

Hi @Johnv, sorry for the late response, I useCode Sniffer with Drupal standards.

  • johnv committed 5a59dbe on 8.x-1.x 
    Issue #2898234: Apply coding standards
mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review

Is there anything left in this issue ?

guilhermevp’s picture

guilhermevp commented
Status: Needs review » Needs work
StatusFileSize
new 2898234-36-WIP.patch21.54 KB

After pulling the most recent version of the branch, I found that there are some work to be done. Sending a new patch, that is not final, but fix some Drupal Coding Standard errors.

  • johnv committed deb60e0 on 8.x-1.x 
    Issue #2898234: Apply coding standards
johnv’s picture

johnv
Primary language Dutch
commented
Version: 8.x-1.x-dev » 8.x-1.3
Status: Needs work » Fixed

Thanks,
but this will be the final patch in this issue. All other PHP Code Sniffer remarks are deliberately not met.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.