The following issue defines the road map for a stable Inline Form Errors module:
#2504847: [meta] Roadmap for stabilizing Inline Form Errors module (IFE)

Currently all Must-haves have been addressed.
All Should-have are either fixed, reviewed and tested by the community, or very close to be so.

Proposal

Move Inline Form Errors out of Core (Experimental) package and into the Core package.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

dmsmidt created an issue. See original summary.

dmsmidt’s picture

Let's at least get the documentation update issue in #2888189: Update hook_help and DO docs for Inline Form Errors and other RTBC's in.

dmsmidt’s picture

Status: Postponed » Needs review
FileSize
527 bytes

Status: Needs review » Needs work

The last submitted patch, 3: 2897652-3-inline_form_errors_in_core_package.patch, failed testing. View results

rootwork’s picture

+++ b/core/modules/inline_form_errors/inline_form_errors.info.yml
@@ -3,4 +3,4 @@ name: Inline Form Errors
 description: 'Adds WCAG 2.0 accessibility compliance for web form errors, but some functionality might not work.'

Is this still true/how we want to phrase this for a core module?

dmsmidt’s picture

@rootwork, it has just been changed, that's why the patch doesn't apply I guess. See #2888189: Update hook_help and DO docs for Inline Form Errors.

dmsmidt’s picture

Double post.

rootwork’s picture

Oh gotcha, sorry for the noise then :)

naiduharish’s picture

Status: Needs work » Needs review
FileSize
483 bytes

Modified patch.

Status: Needs review » Needs work

The last submitted patch, 9: 2897652-9-inline_form_errors_in_core_package.patch, failed testing. View results

naiduharish’s picture

Status: Needs work » Needs review
FileSize
517 bytes

Sorry for wrong file, uploading correct file.

Dries’s picture

+1 from me to move forward with marking this stable, assuming the other committers agree this is ready.

SKAUGHT’s picture

Status: Needs review » Reviewed & tested by the community

#11 manually tested on simplytest.me. looks good.

xjm’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +needs accessibility review, +Needs usability review

All the must-haves are complete. We have a couple should-have issues for the upcoming alpha/beta deadline, two of which are RTBC:

So that part seems ready to go.

We have most of the needed signoffs, from other committers, from the module maintainers, and from Dries. The outstanding must-have from #2504847: [meta] Roadmap for stabilizing Inline Form Errors module (IFE) is full accessibility review. Based on ongoing review from @andrewmacpherson, I think this has probably already happened. However, can we get signoffs from a usability and accessibility maintainer explicitly on the issue so we can mark it stable for this release! The issue can be set RTBC when those signoffs are here.

Edit: Royoy is on vacation so I'd suggest joining a UX meeting or pinging Bojhan for an overall review of the module or simply signoff if it was recently reviewed.

Thanks everyone! This is amazing work.

andrewmacpherson’s picture

Accessibility maintainer review, short version: Yes indeed I've had my head in this all year, testing various issues most weeks. I've been reporting various bugs/quirks along the way. Most of these have been fixed already, and a handful have been classed as non-blocking follow-ups at #2504847: [meta] Roadmap for stabilizing Inline Form Errors module (IFE).

This is so exciting! IFE module goes the extra mile towards addressing WCAG input assistance guidelines in an elegant way which benefits lots of different users and scenarios. For instance, the error jump-links in the help region are categorized merely as an "additional, advisory" technique in WCAG, which just goes to show how far Drupal's accessibility approach has come.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dmsmidt’s picture

Version: 8.5.x-dev » 8.4.x-dev
xjm’s picture

Status: Needs review » Reviewed & tested by the community

I talked to @dmsmidt about the usability review, and he said that each time an issue introduced new designs, it was reviewed at that time in UX meetings. So hopefully that covers the usability gate.

I've marked the module beta at least for now. Looking over the last few should-haves and their status now.

  • xjm committed bbfe8a8 on 8.5.x
    Issue #2897652 by dmsmidt, andrewmacpherson, naiduharish: Move Inline...

  • xjm committed 6842459 on 8.4.x
    Issue #2897652 by dmsmidt, andrewmacpherson, naiduharish: Move Inline...
xjm’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs usability review

Alright, committed and pushed to 8.5.x and 8.4.x! Hopefully we'll see the three should-have issues land soon as well.

xjm’s picture

Issue tags: +8.4.0 release notes
dmsmidt’s picture

Thanks everybody who helped realizing this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.