Move Inline Form Errors module out of Core (Experimental) package and into the Core package

+++ b/core/modules/inline_form_errors/inline_form_errors.info.yml
@@ -3,4 +3,4 @@ name: Inline Form Errors
 description: 'Adds WCAG 2.0 accessibility compliance for web form errors, but some functionality might not work.'

Is this still true/how we want to phrase this for a core module?

Oh gotcha, sorry for the noise then :)

Modified patch.

Sorry for wrong file, uploading correct file.

+1 from me to move forward with marking this stable, assuming the other committers agree this is ready.

#11 manually tested on simplytest.me. looks good.

All the must-haves are complete. We have a couple should-have issues for the upcoming alpha/beta deadline, two of which are RTBC:

• #2482783: File upload errors not set or shown correctly
• #2848507: Indicate that grouping elements have child element errors for ux and a11y
• #2856950: Add a possibility to disable inline form errors for a complete form

So that part seems ready to go.

We have most of the needed signoffs, from other committers, from the module maintainers, and from Dries. The outstanding must-have from #2504847: [meta] Roadmap for stabilizing Inline Form Errors module (IFE) is full accessibility review. Based on ongoing review from @andrewmacpherson, I think this has probably already happened. However, can we get signoffs from a usability and accessibility maintainer explicitly on the issue so we can mark it stable for this release! The issue can be set RTBC when those signoffs are here.

Edit: Royoy is on vacation so I'd suggest joining a UX meeting or pinging Bojhan for an overall review of the module or simply signoff if it was recently reviewed.

Thanks everyone! This is amazing work.

Accessibility maintainer review, short version: Yes indeed I've had my head in this all year, testing various issues most weeks. I've been reporting various bugs/quirks along the way. Most of these have been fixed already, and a handful have been classed as non-blocking follow-ups at #2504847: [meta] Roadmap for stabilizing Inline Form Errors module (IFE).

This is so exciting! IFE module goes the extra mile towards addressing WCAG input assistance guidelines in an elegant way which benefits lots of different users and scenarios. For instance, the error jump-links in the help region are categorized merely as an "additional, advisory" technique in WCAG, which just goes to show how far Drupal's accessibility approach has come.

I talked to @dmsmidt about the usability review, and he said that each time an issue introduced new designs, it was reviewed at that time in UX meetings. So hopefully that covers the usability gate.

I've marked the module beta at least for now. Looking over the last few should-haves and their status now.

Alright, committed and pushed to 8.5.x and 8.4.x! Hopefully we'll see the three should-have issues land soon as well.