IEF integration is broken for bundleless entities, base fields and unsaved form displays

j'ai le même problème avec la version 8.2. Le patch marche pour moi.
Thank!

Patch for 8.x-2.1

I believe it's possible to grab the form display from FormState storage:

+  $storage = $form_state->getStorage();
+
+  if (!empty($storage['form_display'])) {
+    $form_display = $storage['form_display'];
+  }

This will simplify the code a bit.

Bug reports should go always against the dev branch.

I had all these three requirements in one use case

✅ Reference field was a base field
✅ Reference entity type was not bundled
✅ Form was not stored in the DB

All working as expected with the patch.

I think the patch in #6doesn't quite solve this issue, at least not for me.

+++ b/modules/entity_form/entity_browser_entity_form.module
@@ -26,11 +26,19 @@ function entity_browser_entity_form_inline_entity_form_reference_form_alter(&$re
+  $storage = $form_state->getStorage();
+
+  if (!empty($storage['form_display'])) {
+    $form_display = $storage['form_display'];
+  }

This won't work for multiple levels of embedded inline entity forms. The 'form_display' in storage applies to the root entity of the form.

+++ b/modules/entity_form/entity_browser_entity_form.module
@@ -26,11 +26,19 @@ function entity_browser_entity_form_inline_entity_form_reference_form_alter(&$re
+      'bundle' => $instance->getTargetBundle(),

This won't work for base fields, because the $instance variable might be of type BaseFieldDefinition, which doesn't have any information about the bundle in it.

Instead of looking at the field instance (base field or config field) we should look at the parent entity. However there seems to be no easy way to find the parent entity of the field. My suggestion is to propose a patch for the inline entity form that adds the 'parent' to the 'widget state' that is saved to the form_state storage by IEF, so we can use it here.

This patch needs to be used in combination with the patch provided in: https://www.drupal.org/project/inline_entity_form/issues/3253939

Last added patch/change works fine. We need to improve a code in terms to move this issue in Needs Review.

+++ b/modules/entity_form/entity_browser_entity_form.module
@@ -48,8 +73,8 @@ function entity_browser_entity_form_inline_entity_form_reference_form_alter(&$re
   $bundles = $reference_form['entity_id']['#selection_settings']['target_bundles'];

Not sure if this belongs in this issue, but this line makes an assumption there are target bundles, which may not be the case so we get a warning here.

As mentioned in #12, the patch here combined with the one of the MR in #3253939: Add the parent entity to the widget state to fix base fields for Entity Browser fix a problem I encounter when using the an entity browser in a field with inline entity form complex formatter. Without the patch I get the error message mentioned in https://www.drupal.org/project/inline_entity_form/issues/3253939#comment-14478254

Also regarding #15, this seems to have been addressed in another issue: #3283482: Entity browser inline form widget throws warning for bundle-less entities

Please turn this into a MR if still relevant and address the comments above.

It still is relevant, but it's also still postponed on the IEF issue, it only works when combined with that and that's a hard blocker.

There was already an MR, I rebased it, conflicted only on coding style fixes.