Problem/Motivation

Looking through the list of module names: admin/modules#edit-modules-example-modules

...we see that the capitalization of module names is inconsistent. For module names they should all be fully capitalized.

Proposed resolution

For each module we need the following:

Ensure that the module's .info.yml file name: field is fully capitalized, such as "Content Entity Example".

Ensure that the @defgroup tag in the module's .module file is fully capitalized, such as @defgroup content_entity_example Example: Content Entity

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#18 interdiff.txt944 bytesMaskyS
#18 Capitalise_all_module_names-2897096-18.patch9.01 KBMaskyS
#13 interdiff.txt1.77 KBMaskyS
#13 Capitalise_all_module_names-2897096-13.patch9.01 KBMaskyS
#10 Capitalise-all-module-names_2897096_10.patch7.08 KBMaskyS
#7 interdiff.txt1.07 KBmile23
#7 2897096_7.patch6.73 KBmile23
#4 2897096.patch5.66 KBLal_

Comments

Mile23 created an issue. See original summary.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Parent issue: » #2831282: [meta] Inconsistent capitalization in module name / menu links
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes
Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new 2897096.patch5.66 KB

I hope this is what you are looking for.

Lal_’s picture

Lal_
He\Him
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 2897096.patch, failed testing. View results

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs work » Needs review
StatusFileSize
new 2897096_7.patch6.73 KB
new interdiff.txt1.07 KB

Looks like one test needs updating...

Status: Needs review » Needs work

The last submitted patch, 7: 2897096_7.patch, failed testing. View results

MaskyS’s picture

MaskyS commented
Assigned: Unassigned » MaskyS
MaskyS’s picture

MaskyS commented
StatusFileSize
new Capitalise-all-module-names_2897096_10.patch7.08 KB

Fixed all the issues mentioned in issues description. I noticed that there is also an inconsistency concerning the use of single quotes for module names in info.yml files. Only one or two files have the module names enclosed in quotes. @maintainers Should we fix that in a separate issue?

MaskyS’s picture

MaskyS commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: Capitalise-all-module-names_2897096_10.patch, failed testing. View results

MaskyS’s picture

MaskyS commented
StatusFileSize
new Capitalise_all_module_names-2897096-13.patch9.01 KB
new interdiff.txt1.77 KB

Made a few changes to tests that needed updating. Should pass now.

MaskyS’s picture

MaskyS commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: Capitalise_all_module_names-2897096-13.patch, failed testing. View results

navneet0693’s picture

navneet0693 commented 
+++ b/src/Tests/ExamplesTest.php
@@ -48,7 +48,8 @@ class ExamplesTest extends WebTestBase {
+    $phpunit_link = 'PHPUnit example';

Replace with 'PHPUnit Example'

MaskyS’s picture

MaskyS commented

Gotcha.

MaskyS’s picture

MaskyS commented
StatusFileSize
new Capitalise_all_module_names-2897096-18.patch9.01 KB
new interdiff.txt944 bytes

Alright, let's test this again.

MaskyS’s picture

MaskyS commented
Status: Needs work » Needs review
navneet0693’s picture

navneet0693 commented
Status: Needs review » Reviewed & tested by the community

That should be all.

  • Mile23 committed 1adab71 on 8.x-1.x authored by AbhishekLal 
    Issue #2897096 by Kifah Meeran, Mile23, AbhishekLal, navneet0693:...
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Reviewed & tested by the community » Fixed

Done. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.