* Disable overlay module.
* Delete a site backup using the aegir interface.
* Confirm the deletion

Fatal error: Call to undefined function overlay_close_dialog() in /var/aegir/hostmaster-7.x-3.11/profiles/hostmaster/modules/aegir/hosting_site_backup_manager/hosting_site_backup_manager.module on line 212

- Module should check if overlay is available before using overlay functions.

CommentFileSizeAuthor
#2 hosting_site_backup_manager-check_overlay-2897017-1-D7.patch897 bytesmillenniumtree

Comments

millenniumtree created an issue. See original summary.

millenniumtree’s picture

millenniumtree
he/him
Location Holualoa, HI
commented
Version: 7.x-3.11 » 7.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new hosting_site_backup_manager-check_overlay-2897017-1-D7.patch897 bytes

Wrapped the overlay_close_dialog() calls with if (module_exists('overlay')) {}

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Makes sense to me.

  • helmo committed 8433fa8 on 7.x-3.x authored by millenniumtree 
    Issue #2897017 by millenniumtree: Fatal error on backup deletion if...
helmo’s picture

helmo commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

luongosb’s picture

luongosb commented

Could this also be added to hosting_site_backup_manager?

profiles/hostmaster/modules/aegir/hosting_site_backup_manager/hosting_site_backup_manager.module

Thank you!

helmo’s picture

helmo commented

It should be in there if you have upgraded to 3.12.0 or later. Please create a new issue referencing this one if you still have this problem after updating.