See the change record: The internal page cache now has a dedicated cache bin.
This means that, in ViewsTest, where we clear the static and dynamic page cache, we now need to change cache.render to cache.page – or, to stay compatible with Drupal 8.3.x (for now).

CommentFileSizeAuthor
#5 2896878-5--fix_tests_page_cache.patch840 bytesdrunken monkey
#2 2896878-2--fix_tests_page_cache.patch819 bytesdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2896878-2--fix_tests_page_cache.patch819 bytes

This should do it.
(Btw: We already have a test fail which looks like it could be caused by this. No idea why the other 8.4 environment didn't fail, though.)

  • drunken monkey committed ca3de3a on 8.x-1.x 
    Issue #2896878 by drunken monkey: Fixed test fails due to latest Core...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Seems this also caused problems with patches sometimes, so I rather committed right away.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Fixed » Needs review
StatusFileSize
new 2896878-5--fix_tests_page_cache.patch840 bytes

Unsurprisingly, if we request (and clear) the cache.page service unconditionally, tests will fail when that service doesn't exist. The attached should fix the tests on 8.3, too.

  • drunken monkey committed 6e48dd4 on 8.x-1.x 
    Follow-up to #2896878 by drunken monkey: Fixed tests on Drupal 8.3.
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.