There's a lot of "invalid argument supplied for foreach()" happening on PHP 5.6.30:

Warning: Invalid argument supplied for foreach() in Drupal\menu_link_content_visibility\MenuLinkContentVisibilityCache->buildConditions() (line 81 of /var/www/website-name-here/modules/contrib/menu_link_content_visibility/src/MenuLinkContentVisibilityCache.php) #0

CommentFileSizeAuthor
#8 2896687-8.patch1.45 KBxavier.masson
#2 2896687-2.patch2.81 KBjzavrl

Comments

CatherineOmega created an issue. See original summary.

jzavrl’s picture

jzavrl commented
Status: Active » Needs review
StatusFileSize
new 2896687-2.patch2.81 KB

Have also gotten those myself on 1.x-dev. There is also a different one: Warning: Invalid argument supplied for foreach() in Drupal\menu_link_content_visibility\MenuLinkContentVisibilityChecker->isVisible() (line 50 of modules/contrib/menu_link_content_visibility/src/MenuLinkContentVisibilityChecker.php)..

Attached patch fixes both of these issues in classes MenuLinkContentVisibilityChecker and MenuLinkContentVisibilityCache .

CatherineOmega’s picture

CatherineOmega commented

This takes care of both issues and the code looks good to me. Anyone else want to take a look?

luisortizramos’s picture

luisortizramos commented

Patch added and commited to the dev branch.

Thank you jzavrl and CatherineOmega

luisortizramos’s picture

luisortizramos commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xavier.masson’s picture

xavier.masson
Primary language French
Location Haute-Normandie
commented
StatusFileSize
new 2896687-8.patch1.45 KB
slefevre@ccad.edu’s picture

slefevre@ccad.edu commented

This thread says that the bug is closed, but I just installed 1.1 and I'm getting the error. Was this rolled into 1.1, or is it just in dev?

luisortizramos’s picture

luisortizramos commented

Good morning,

I've just created a new release that includes this commit. This way we don't need to use the dev version anymore.

KR,