I'm just wondering what the purpose the meta_header has?

When I enable my subtheme, lots of blocks end up there. Is that intentional?

CommentFileSizeAuthor
#7 regionscaps-2896247-7.patch1.57 KBhongpong
#6 regionscaps-2896247-6.patch0 byteshongpong

Comments

pektinasen created an issue. See original summary.

manyk’s picture

manyk commented

As stated by @samuel.mortenson in his commit: http://cgit.drupalcode.org/zurb-foundation/commit/?h=8.x-6.x&id=427b634f6b4a915e594ad954010a0311c30bb8bf

the Meta Header is added in order to allow full width navs to always float above the page.
manyk’s picture

manyk commented

Usualy, unnasigned blocks ends up in the 1st available region - in this case Meta Header.
But I see there is a small difference between the Zurb main theme and the child theme: Meta Header and Header are switched.

serg2’s picture

serg2 commented

I think we should close this issue and possibly open an issue to correct what Manyk describes, align the ordering of regions in STARTER/STARTER.info.yml.txt with those in zurb_foundation.info.yml, unless there is a reason for the difference.

pektinasen’s picture

pektinasen commented

Thank you for the clarification

hongpong’s picture

hongpong commented
Title: What is the region meta_header for? » What is region meta_header for? Region order differs in STARTER
Status: Active » Needs review
StatusFileSize
new regionscaps-2896247-6.patch0 bytes

This fixes the capitalization on both the core and STARTER themes and makes their order consistent across both.

hongpong’s picture

hongpong commented
StatusFileSize
new regionscaps-2896247-7.patch1.57 KB

Oops here is the correct patch.

sim_1’s picture

sim_1
she/her
commented
Status: Needs review » Reviewed & tested by the community

I just tested this patch on the latest 8.x-6.x dev branch and it worked as described. Marking as RTBC so that this cleanup can get into future releases.

  • HongPong committed c0b23c1 on 8.x-6.x 
    Issue #2896247 by HongPong, manyk, serg2, sim_1: Region meta_header and...
hongpong’s picture

hongpong commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review and attention to this sim_1, appreciate it!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.