The live loading of new messages in a given thread does not work correctly on my local install.
Upon further debugging, I noticed an issue with the $private_message_thread->isMember() function calls in this class: they get passed the whole $account object, where an ID is expected.

Patch fixing this issue following.

CommentFileSizeAuthor
#2 incorrect_ismember-2895612-2.patch1.06 KBsvendecabooter

Comments

svendecabooter created an issue. See original summary.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Active » Needs review
StatusFileSize
new incorrect_ismember-2895612-2.patch1.06 KB
jaypan’s picture

jaypan
Location Victoria, BC
commented

Thanks, I'll take a look at this in the next couple of days. Much appreciated.

boshtian’s picture

boshtian commented

Because of this issue, only the messages current user sends are loaded into the thread.

The patch fixes the issue as it passes the ID of the user to the isMember function instead of the object.

I confirm that this patch works.

utement’s picture

utement commented

PAtch tested and I can confirm that it fixes issues with loading messages.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Reviewed & tested by the community

Marking as RTBC given feedback / reviews above.

heilop’s picture

heilop commented
Issue tags: +Nashville2018

The patch looks ok.

edutrul’s picture

edutrul commented
Status: Reviewed & tested by the community » Fixed

Excellent job svendecabooter, Jaypan, boshtian, utement, heilop
works as expected! pushed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.