Closed (fixed)
Project:
Views Reference Field
Version:
8.x-1.0-beta2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Jul 2017 at 16:29 UTC
Updated:
22 Dec 2017 at 23:46 UTC
Jump to comment: Most recent
Comments
Comment #2
maxilein commentedComment #3
seanbThat submodule was removed in 2.x. You need to uninstall the module before doing the upgrade and clear the cache. Thank for reporting this, I will add some information to the project page!
Comment #4
NewZeal commentedI've released rc1 which does not have the submodule in it. That submodule was never meant to be in there in the first place. Your error does however highlight a problem with the Drupal.org packaging script in that it attempted to validate a module that I thought had been disabled.
Comment #5
maxilein commented@seanB Uninstalling is never an option if the module has been in use. All settings would be lost.
@new zeal: thank you for the rc1 I will test it and report back.
Comment #6
NewZeal commented@maxilein, yes sorry about what happened. Hopefully we got on top of it fast enough before it affected too many people. There are unknown numbers of people doing automatic builds using composer and things like that break quite a bit of internet!
Comment #7
seanbI believe the module was empty and didn't provide anything to lose right?
Please correct me is I'm wrong! If you have a way to fix the upgrade path I would be happy to fix this.
Comment #8
NewZeal commentedrc1 should have fixed it. I didn't meant to include the module in the last push. Obviously that module is redundant now, although there is some merit in providing the advanced options as a separate module. Would you consider putting all your 2.x plugins bar title and argument into a separate module?
Comment #9
seanbDo you mean adding back the extra module to 1.x for the plugins and adding the plugin manager to the 1.x version as well? Or is the goal to remove the 2.x branch? I already upgraded some sites, so needing to downgrade to 1.x again would be an issue.
Comment #10
NewZeal commentedI created a blank module called viewsreference_options but the 2.x development that you are doing does not require the module. Is that not correct?
Comment #11
seanbOw, I understand what you mean. It's possible to add all the advanced options in a separate module in 2.x. Let's add a separate issue for this.
Comment #12
maxilein commentedrc1 fixed it for me. Thank you!
Comment #13
NewZeal commentedYes, it is probably wise to make it a separate module. Otherwise people who want the simple version will end up with a whole lot of stuff they don't want.
Comment #14
seanbCreated #2896326: Disable extra settings by default to fix this. Instead of adding a separate module, I chose to switch the settings from opt-out to opt-in. This way the extra settings are hidden unless explicitly enabled by the user. This is probably a far better default since I always found the title/argument field confusing for most users as well. The title/argument field are enabled in the upgrade path for users upgrading from 1.x for BC.
Let's continue the discussion in the other issue and let me know what you think.
Comment #15
NewZeal commentedPresume fixed.
Comment #16
NewZeal commented