Image popup depends on the core library core/drupal.dialog.ajax which is not always added, so it needs to be attached in order to make sure that it will be always there.

CommentFileSizeAuthor
#2 image_popup-attach_dialog_library-2894624-2.patch782 bytesruloweb

Comments

ruloweb created an issue. See original summary.

ruloweb’s picture

ruloweb commented
StatusFileSize
new image_popup-attach_dialog_library-2894624-2.patch782 bytes

Patch attached.

ruloweb’s picture

ruloweb commented
Status: Active » Needs review
anairamzap’s picture

anairamzap
she/her
Primary language Spanish
Location 🇦🇷 ✌🏽 Buenos Aires
commented

I reviewed the patch on #2 and it works as expected :)
(Drupal 8.3.5)

VeroKrings’s picture

VeroKrings commented

Tested > The patch on #2 works as expected.

fabiansierra5191’s picture

fabiansierra5191 commented
Issue tags: +DrupalPicNic

The patch on #2 is working as expected!
Tested on Drupal 8.3.5 version, Chrome and Firefox browsers for authenticated and anonymous users!

tucho’s picture

tucho
Primary language Spanish
Location Buenos Aires
commented
Status: Needs review » Reviewed & tested by the community

I have tested the patch on #2 with Drupal 8.3.5 and it work as expected.

aporie’s picture

aporie
Primary language French
commented

The issue still exists when using image popup in the Wysiwyg then.

By default, drupal.dialog.ajax is not loaded for anonymous users. You should add this dependency in your custom theme libraries.yml:

dependencies: 
  - core/drupal.dialog.ajax

I think this should be added to the project page (or somewhere in a doc page).

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

I am not sure about the above comment. Thanks for the patch, And it is applying correctly.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

  • ruloweb authored f3ffd02 on 8.x-1.x 
    Issue #2894624 by ruloweb, rakesh.gectcr, VeroKrings, anairamzap,...
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented

Thank you all for your contribution.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language English
Location Manchester
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tomchy’s picture

tomchy commented

The patch not working on 8.8.5 (on 8.x-1.1)

dev version not working at all (missing insert icon on CKEditor)