On a page with horizontal tabs, the module repeats the title, despite the page not having changed.

breadcrumbs tabs bug

CommentFileSizeAuthor
#7 interdiff.txt690 bytestatarbj
#7 easy_breadcrumb-check_shown_in_breadcrumb-2893840-7.patch2.04 KBtatarbj
#4 Screen Shot 2018-01-21 at 1.31.04 PM.png27.15 KBjenlampton
#4 easy_breadcrumb-check_shown_in_breadcrumb-2893840-4.patch2.04 KBjenlampton
easy_breadcrumb-tabs.PNG19.19 KB.tom

Comments

.tom created an issue. See original summary.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

What's the URL for this page?

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Assigned: Unassigned » tatarbj
Status: Active » Needs work

It's a /user page on our product after log in.
I think the report is valid and should be handled as more generic improvement for the next release because tabs should be handled by easy breadcrumb even url doesn't change.
I'm gonna get back here at most in a few days!
Thanks Tom for the report and great testing ;)
Bests,
Balazs.

jenlampton’s picture

jenlampton
she / her
commented
Title: Problem with horizontal tabs » Druplicate breadcrumbs appearing on admin pages with menu local tasks
Status: Needs work » Needs review
StatusFileSize
new easy_breadcrumb-check_shown_in_breadcrumb-2893840-4.patch2.04 KB
new Screen Shot 2018-01-21 at 1.31.04 PM.png27.15 KB

This is easy to see on the Blocks page for the Seven theme (admin/structure/block/list/seven), with the "Block" crumb being listed twice, once linking to `admin/structure/block` and once to `admin/structure/block/list`.

On both those paths the same resulting html markup will be shown, as `admin/structure/block/list` is the default local task for `admin/structure/block`.

Drupal includes a special menu item type MENU_VISIBLE_IN_BREADCRUMB that determines when one of these links should be shown in the breadcrumb trail. All we need to do is check this setting before adding the breadcrumb, and it should fix the problem.

Attaching a patch for review.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented

I like the way how you handle it @jenlampton! Let me test it a bit deeper and get back in a few days.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Parent issue: » #2938503: New minor release of 7.x
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new easy_breadcrumb-check_shown_in_breadcrumb-2893840-7.patch2.04 KB
new interdiff.txt690 bytes

After testing it now with a small typo i just fixed (see patch and interdiff) and i'm about to commit it to dev.
Thanks @jenlampton!

  • tatarbj committed 261af75 on 7.x-2.x 
    Issue #2893840 by tatarbj, jenlampton, .tom, Greg Boggs: Duplicate...
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Title: Druplicate breadcrumbs appearing on admin pages with menu local tasks » Duplicate breadcrumbs appearing on admin pages with menu local tasks
Assigned: tatarbj » Unassigned
Status: Reviewed & tested by the community » Fixed

typo fix in the title and after the commit, closing the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.