Hi!
We would like to ensure that all Commerce 2.x payment gateways have Ludwig integration, to ensure that they can be installed without Composer.

You can find out more about Ludwig from this blog post: https://drupalcommerce.org/blog/49669/installing-commerce-2x-without-com...
And you can find a sample Ludwig integration here: http://cgit.drupalcode.org/commerce_ingenico/commit/?id=364f5ea

Notes:

- If your SDK has a dependency of its own in its composer.json, you must list that in the ludwig.json file as well

- You do not need to list dependencies that are included in Drupal core (such as Symfony)

If you have any doubts, you can post a patch to this issue first, and then someone from the Commerce Guys team will review.

Thank you!

CommentFileSizeAuthor
#4 2892635-4.patch290 bytesdevad

Comments

krcha created an issue. See original summary.

krcha’s picture

krcha commented
Status: Active » Closed (won't fix)

Sorry, just realized that this module doesn't require an external SDK.

devad’s picture

devad commented

Re:

Sorry, just realized that this module doesn't require an external SDK.

This has changed.

There is dependancy on "webmozart/assert": "*" in composer.json now.

{
  "name": "drupal/commerce_paytrail",
  "type": "drupal-module",
  "homepage": "http://drupal.org/project/commerce_paytrail",
  "license": "GPL-2.0+",
  "minimum-stability": "dev",
  "require": {
    "php": ">=7.1",
    "webmozart/assert": "*",
    "drupal/commerce": "^2"
  }
}

ludwig.json file is needed as follows:

{
  "require": {
    "webmozart/assert": {
      "version": "v1.9.1",
      "url": "https://github.com/webmozart/assert/archive/1.9.1.zip"
    }
  }
}
devad’s picture

devad commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Status: Closed (won't fix) » Needs review
StatusFileSize
new 2892635-4.patch290 bytes

The 2.x branch is not passing tests?

Status: Needs review » Needs work

The last submitted patch, 4: 2892635-4.patch, failed testing. View results

devad’s picture

devad commented
Title: Add Ludwig integration » Commerce Paytrail - Add Ludwig integration
devad’s picture

devad commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 2892635-4.patch, failed testing. View results

devad’s picture

devad commented
Status: Needs work » Needs review

It seems the branch tests need repair.

#3174994: Fix FunctionalJavascript tests

In the meantime, switching this back to "Needs review".

  • tuutti committed a9e2296 on 8.x-2.x authored by devad 
    Issue #2892635 by devad: Commerce Paytrail - Add Ludwig integration
  • tuutti committed cd35a00 on 8.x-2.x
    Merge branch '2892635' into '8.x-2.x'

Issue #2892635 by devad: Commerce...
tuutti’s picture

tuutti commented
Status: Needs review » Fixed

Hi,

I use gitlab CI to run tests, so I never bothered to setup testing for 8.x branches. Should be enabled now.

I'm not that familiar with Ludwig, but I'm pretty sure webmozart/assert is already required by some dependency.

Running composer depends webmozart/assert on clean 8.9.x core shows that core requires it, but I'm pretty sure it's not actually included in core, so it might be worth to add it as ludwig dependency just in case.

tuutti’s picture

tuutti commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.